newsletter-to-web
/
newsletter-to-web
1
0
Fork 0
Code Issues 4 Pull Requests Projects Releases 4 Activity

Add stylesheet in a clean way #13

Merged
jjkiers merged 5 commits from contribute-stylesheet into master 2022-12-27 22:09:03 +00:00
Conversation 2 Commits 5 Files Changed 8 +86 -67
jjkiers commented 2022-12-13 20:04:36 +00:00
Owner
Copy Link

This was contributed in https://github.com/rust-syndication/atom/pull/68.

Closes #12.

This was contributed in https://github.com/rust-syndication/atom/pull/68. Closes #12.
jjkiers added 1 commit 2022-12-13 20:04:36 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
34d301590e Use feed::set_stylesheet instead of hack 
This was contributed in https://github.com/rust-syndication/atom/pull/68.

Closes #12.

Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>
jjkiers commented 2022-12-13 20:05:13 +00:00
Author
Owner
Copy Link

Just waiting until the contributed PR is accepted (or rejected).

Just waiting until the contributed PR is accepted (or rejected).
jjkiers added 3 commits 2022-12-14 14:49:02 +00:00
21bdb9488e Put real feed url into feed 
Instead of hardcoding the feed file name to be feed.atom, it has been
configurable for a while. This is now also reflected in the feed itself.

Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>
aef3cb592a Fix CS and some other small things 
Useful tool, that clippy...

Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>
continuous-integration/drone/push Build is running Details
continuous-integration/drone/pr Build is running Details
ec6034cee7 Update changelog 
Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>
jjkiers added 1 commit 2022-12-14 15:00:05 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build was killed Details
e4ac6c9657 Truncate the feed file before writing 
Otherwise, the feed may be overwritten, but if it is shorter, it may
contain some leftover data from a previous run. In that case, the file
will be invalid XML, thereby failing to be parsed.

Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>
jjkiers force-pushed contribute-stylesheet from e4ac6c9657 to 86f3430993 2022-12-16 18:35:35 +00:00 Compare
jjkiers added the
maintenance
 label 2022-12-27 19:46:03 +00:00
jjkiers force-pushed contribute-stylesheet from 86f3430993 to 4069d8ac31 2022-12-27 22:01:05 +00:00 Compare
jjkiers changed title from Use feed::set_stylesheet instead of hack to Add stylesheet in a clean way 2022-12-27 22:03:49 +00:00
jjkiers commented 2022-12-27 22:07:50 +00:00
Author
Owner
Copy Link

Updated based on https://github.com/rust-syndication/atom/pull/70, rebased and cleaned up.

Updated based on https://github.com/rust-syndication/atom/pull/70, rebased and cleaned up.
jjkiers merged commit 4069d8ac31 into master 2022-12-27 22:09:03 +00:00
jjkiers deleted branch contribute-stylesheet 2022-12-27 22:09:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
maintenance

Non-feature developments

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
feature
help wanted
invalid
maintenance
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: newsletter-to-web/newsletter-to-web#13
No description provided.
Delete Branch "contribute-stylesheet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?