Ensure demo setting is '' or 'enabled'

migrations/20190725172940-settings-migrate-cloudron-conf.js

@@ -1,8 +1,7 @@
 'use strict';
 
 var async = require('async'),
-    fs = require('fs'),
-    superagent = require('superagent');
+    fs = require('fs');
 
 exports.up = function(db, callback) {
     if (!fs.existsSync('/etc/cloudron/cloudron.conf')) {

migrations/20191002103646-fix-demo-settings-boolean.js

@@ -0,0 +1,16 @@
+'use strict';
+
+exports.up = function(db, callback) {
+    db.all('SELECT * FROM settings WHERE name="demo"', function (error, result) {
+        if (error) console.error(error);
+
+        // only 'enabled' and '1' is supported from here on, falsy is empty string like other boolean settings
+        var isDemo = result[0].demo === '1' || result[0].demo === 'enabled';
+
+        db.runSql('REPLACE INTO settings (name, value) VALUES(?, ?)', [ 'demo', isDemo ? 'enabled' : '' ], callback);
+    });
+};
+
+exports.down = function(db, callback) {
+    callback();
+};