Girish Ramakrishnan
5f9b2f1159
Add env and debug mode tests
2019-09-09 15:46:29 -07:00
Girish Ramakrishnan
801ca7eda1
Break down the configure route
2019-09-09 14:35:52 -07:00
Girish Ramakrishnan
45a2d3745c
Fix app eventlog
2019-09-06 14:47:44 -07:00
Girish Ramakrishnan
551fe4d846
Use BoxError everywhere in apptask
2019-09-06 11:33:24 -07:00
Girish Ramakrishnan
791981c2f2
trim the provider
2019-09-06 10:24:19 -07:00
Girish Ramakrishnan
a18a620847
Add BoxError.toPlainObject
2019-09-05 21:11:38 -07:00
Girish Ramakrishnan
99e63ffc3f
Use BoxError for apptask errors
2019-09-05 18:13:53 -07:00
Girish Ramakrishnan
e10a6d9de5
Bump graphite for buffer size fix
2019-09-05 14:33:32 -07:00
Girish Ramakrishnan
147f16571a
Handle error in graphs code
2019-09-05 14:30:21 -07:00
Girish Ramakrishnan
bd1fbc4a05
typo
2019-09-05 11:42:32 -07:00
Girish Ramakrishnan
0843f78ec8
Add tasks.setCompleted
...
this lets us easily grep the code on where the task is completed
2019-09-05 11:29:48 -07:00
Girish Ramakrishnan
9769fbfcf2
Better message
2019-09-05 11:22:29 -07:00
Girish Ramakrishnan
7e73197eb9
Trigger re-configure of apps for collectd config
2019-09-05 09:24:37 -07:00
Girish Ramakrishnan
e3964fd710
Fix crash in setUpdateSuccess
v4.2.0
2019-09-04 16:11:59 -07:00
Girish Ramakrishnan
e66961b814
merge registerSubdomains and registerAlternateDomains
...
also, merge unregisterSubdomain and unregisterAlternateDomains
also, fix crash where app.oldConfig is used
2019-09-03 19:55:41 -07:00
Girish Ramakrishnan
4176e5a98e
Add note in schema
2019-09-03 19:04:12 -07:00
Girish Ramakrishnan
45cf8a62d1
remove obsolete comment
2019-09-03 18:52:37 -07:00
Girish Ramakrishnan
b1380819ba
debug taskId
2019-09-03 16:06:28 -07:00
Girish Ramakrishnan
57fa457596
Typo in error handling
2019-09-03 15:55:57 -07:00
Girish Ramakrishnan
de1e218ce9
Return BAD_FIELD if dataDir conflicts
2019-09-03 15:17:48 -07:00
Girish Ramakrishnan
e117ee2bef
Cleanup app error codes
...
1. The error classes (like AppsError) now take a 3rd argument details.
We can attach anything in this 3rd argument and this gets sent in the
REST response as well.
2. The HttpError class is now HttpError(statusCode, errorOrMessage). If
it's an error object, it will take the message and other things which
were attached above from it and send them across. Previously, we used to
mark this case an internal error all the time.
3. AppsError only has generic codes now. The UI code then simply checks
for additional information that we attached to show errors. For example,
BAD_FIELD will have a field: 'xx' indicating which field is at fault.
ALREADY_EXISTS has information on which domain or port caused a problem.
The advantage here is we can drop all these error codes that are
specific to each model code.
4. Maybe some day, we can remove all these error classes and have only
one generic class. AppsError right now is pretty generic already. We can
use that error code everywhere... No need to translate errors also
everywhere.
5. Finally, in the router code, I have this function toHttpError (in
apps.js) which is also so much cleaner than what we have now. We keep
writing the same stuff over and over.
2019-09-03 10:39:02 -07:00
Girish Ramakrishnan
a9e101d9f4
Add note on why it is BAD_STATE
2019-09-02 13:55:43 -07:00
Girish Ramakrishnan
a2f8203a42
Add location conflict error code
2019-09-02 12:42:28 -07:00
Girish Ramakrishnan
b9ee127775
Send detail in apps error
2019-09-02 12:41:32 -07:00
Girish Ramakrishnan
6668bb3e8a
Handle BAD_STATE as well
2019-09-02 12:17:48 -07:00
Girish Ramakrishnan
5fd129e509
send reason code as part of details
2019-09-01 21:22:46 -07:00
Girish Ramakrishnan
d59c1f53b9
apps: add detail to http error messages
2019-09-01 18:35:06 -07:00
Girish Ramakrishnan
d2f38c1abc
Remove unused error code
2019-09-01 17:39:07 -07:00
Girish Ramakrishnan
c0a1db6941
Send details as part of AppsError
...
the last mile module has been updated to pipe through additional properties.
2019-09-01 13:42:25 -07:00
Girish Ramakrishnan
fc10b4a79b
Update lastmile
2019-09-01 13:34:40 -07:00
Girish Ramakrishnan
9da2117e99
Re-enable configure/restore test
2019-08-30 16:12:35 -07:00
Girish Ramakrishnan
7e030b149b
More changes
2019-08-30 15:51:50 -07:00
Girish Ramakrishnan
bd23abd265
tasks: make error a json
...
also, handle case where we never got to handle task exit cleanly
2019-08-30 14:49:45 -07:00
Girish Ramakrishnan
dd0fb8292c
Move state enums to the model code
2019-08-30 13:21:51 -07:00
Girish Ramakrishnan
b4cbf63519
Remove installationState contraint when settings health
2019-08-30 12:57:59 -07:00
Girish Ramakrishnan
4fd04fa349
Add proper error codes
2019-08-30 12:42:38 -07:00
Girish Ramakrishnan
c22cdb8d81
Return error object in the API
2019-08-30 11:34:04 -07:00
Johannes Zellner
eb963b2eb4
Add externalldap pagination
2019-08-30 20:26:09 +02:00
Girish Ramakrishnan
7d299908c9
Fix tests
2019-08-30 10:49:43 -07:00
Girish Ramakrishnan
2585282f86
errorMessage -> errorJson
2019-08-30 10:02:24 -07:00
Johannes Zellner
f25d5b3304
Deliver the user account source in the profile api
2019-08-30 13:36:37 +02:00
Johannes Zellner
6e878faa8b
Also sync fallbackEmail from ldap
2019-08-30 13:10:49 +02:00
Johannes Zellner
15a6cbe62b
Make sure all password change input fields use the same validation pattern
2019-08-30 12:14:32 +02:00
Johannes Zellner
76b0b214ec
Do not sync non-ldap users from ldap if usernames match
...
We might want to make that option in the future depending on use-cases
2019-08-30 10:20:04 +02:00
Johannes Zellner
f5c643c960
Add some debugging logs when users are created or updated
2019-08-30 10:20:04 +02:00
Johannes Zellner
ca8e0613fb
Skip notifications for ldap syncer events
2019-08-30 10:20:04 +02:00
Johannes Zellner
0c9334d0d2
Ensure we wait for all user sync db actions to finish
2019-08-30 10:20:04 +02:00
Johannes Zellner
712dc97e9b
Move the basic ldap argument validation
2019-08-30 10:20:04 +02:00
Johannes Zellner
4df48c97ec
Ignore the bindDn user in the syncer
2019-08-30 10:20:04 +02:00
Johannes Zellner
fe3ea53cda
Ldap usually uses cn as displayName
2019-08-30 10:20:04 +02:00