preserve sorting order when doing async queries

2020-09-16 16:03:14 -07:00
parent f114a629f3
commit f5e0ff51f2
1 changed files with 2 additions and 2 deletions
--- a/src/views/users.js
+++ b/src/views/users.js
@@ -660,11 +660,11 @@ angular.module('Application').controller('UsersController', ['$scope', '$locatio
        Client.getUsers($scope.userSearchString, $scope.currentPage, $scope.pageItems.value, function (error, results) {
            if (error) return console.error(error);

-            async.eachLimit(results, 20, function (result, iteratorDone) {
+            async.eachOfLimit(results, 20, function (result, index, iteratorDone) {
                Client.getUser(result.id, function (error, user) {
                    if (error) return iteratorDone(error);

-                    users.push(user);
+                    users[index] = user; // keep the sorting order

                    iteratorDone();
                });