From f5e0ff51f25c221aa307d9bbebfcf07f7974becd Mon Sep 17 00:00:00 2001 From: Girish Ramakrishnan Date: Wed, 16 Sep 2020 16:03:14 -0700 Subject: [PATCH] preserve sorting order when doing async queries --- src/views/users.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/views/users.js b/src/views/users.js index d38cf78e2..999217415 100644 --- a/src/views/users.js +++ b/src/views/users.js @@ -660,11 +660,11 @@ angular.module('Application').controller('UsersController', ['$scope', '$locatio Client.getUsers($scope.userSearchString, $scope.currentPage, $scope.pageItems.value, function (error, results) { if (error) return console.error(error); - async.eachLimit(results, 20, function (result, iteratorDone) { + async.eachOfLimit(results, 20, function (result, index, iteratorDone) { Client.getUser(result.id, function (error, user) { if (error) return iteratorDone(error); - users.push(user); + users[index] = user; // keep the sorting order iteratorDone(); });