jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Do not use db directly in routes

Browse Source 
Part of #57
This commit is contained in:
Girish Ramakrishnan
2014-08-13 14:32:44 -07:00
parent ed28afdb78
commit cf748fe501
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/routes/settings.js
+4 -3
View File
@@ -8,7 +8,8 @@ var HttpError = require('../httperror.js'),
DatabaseError = require('../databaseerror.js'),
apptask = require('../apptask.js'),
config = require('../../config.js'),
appdb = require('../appdb.js');
apps = require('../apps.js'),
AppsError = apps.AppsError;
exports = module.exports = {
getNakedDomain: getNakedDomain,
@@ -25,10 +26,10 @@ function setNakedDomain(req, res, next) {
var data = req.body;
if (!data || typeof data.appid !== 'string') return next(new HttpError(400, 'appid is required'));
function getApp(appid, callback) { return appid !== '' ? appdb.get(appid, callback): callback(null); }
function getApp(appid, callback) { return appid !== '' ? apps.get(appid, callback): callback(null); }
getApp(data.appid, function (error, app) {
if (error && error.reason === DatabaseError.NOT_FOUND) return next(new HttpError(404, 'No such app'));
if (error && error.reason === AppsError.NOT_FOUND) return next(new HttpError(404, 'No such app'));
apptask.setNakedDomain(app, function (error) {
if (error) return next(new HttpError(500, 'Error setting naked domain: ' + error));