Remove skipNotification flag

we always want a update finish eventlog. Otherwise, the eventlog seems strange since it says 'started updated' but didn't finish
2019-09-26 20:06:12 -07:00
parent 44aba5d6e1
commit a266fe13d0
4 changed files with 2 additions and 5 deletions
@@ -932,9 +932,7 @@ function update(app, args, progressCallback, callback) {
            debugApp(app, 'Error updating app: %s', error);
            updateApp(app, { installationState: apps.ISTATE_ERROR, error: makeTaskError(error, app) }, callback.bind(null, error));
        } else {
-            if (updateConfig.skipNotification) return callback(null);
-
-            eventlog.add(eventlog.ACTION_APP_UPDATE_FINISH, auditsource.APP_TASK, { app: app, success: true }, callback);
+            eventlog.add(eventlog.ACTION_APP_UPDATE_FINISH, auditsource.APP_TASK, { app: app, success: true }, () => callback()); // ignore error
        }
    });
 }