diff --git a/src/apps.js b/src/apps.js index 892d1542b..eae82cdc0 100644 --- a/src/apps.js +++ b/src/apps.js @@ -1258,7 +1258,6 @@ function update(appId, data, auditSource, callback) { if (error) return callback(error); var updateConfig = { - skipNotification: !!data.skipNotification, skipBackup: !!data.skipBackup }; diff --git a/src/apptask.js b/src/apptask.js index bef8cd3d0..c8e7bab46 100644 --- a/src/apptask.js +++ b/src/apptask.js @@ -932,9 +932,7 @@ function update(app, args, progressCallback, callback) { debugApp(app, 'Error updating app: %s', error); updateApp(app, { installationState: apps.ISTATE_ERROR, error: makeTaskError(error, app) }, callback.bind(null, error)); } else { - if (updateConfig.skipNotification) return callback(null); - - eventlog.add(eventlog.ACTION_APP_UPDATE_FINISH, auditsource.APP_TASK, { app: app, success: true }, callback); + eventlog.add(eventlog.ACTION_APP_UPDATE_FINISH, auditsource.APP_TASK, { app: app, success: true }, () => callback()); // ignore error } }); } diff --git a/src/notifications.js b/src/notifications.js index f583d8f32..65bd8f5a0 100644 --- a/src/notifications.js +++ b/src/notifications.js @@ -370,6 +370,7 @@ function onEvent(id, action, source, data, callback) { return appUp(id, data.app, callback); case eventlog.ACTION_APP_UPDATE_FINISH: + if (!data.app.appStoreId) return callback(); // skip notification of dev apps return appUpdated(id, data.app, callback); case eventlog.ACTION_CERTIFICATE_RENEWAL: diff --git a/src/routes/apps.js b/src/routes/apps.js index a6bbcb3c5..d7085760a 100644 --- a/src/routes/apps.js +++ b/src/routes/apps.js @@ -490,7 +490,6 @@ function updateApp(req, res, next) { if (!data.manifest && !data.appStoreId) return next(new HttpError(400, 'appStoreId or manifest is required')); if ('skipBackup' in data && typeof data.skipBackup !== 'boolean') return next(new HttpError(400, 'skipBackup must be a boolean')); - if ('skipNotification' in data && typeof data.skipNotification !== 'boolean') return next(new HttpError(400, 'skipNotification must be a boolean')); if ('force' in data && typeof data.force !== 'boolean') return next(new HttpError(400, 'force must be a boolean')); debug('Update app id:%s to manifest:%j', req.params.id, data.manifest);