add a TODO

This commit is contained in:
Girish Ramakrishnan
2023-07-14 08:34:02 +05:30
parent 4c24de53e4
commit 866cf75012

View File

@@ -2741,6 +2741,7 @@ async function restartAppsUsingAddons(changedAddons, auditSource) {
assert.strictEqual(typeof auditSource, 'object');
let apps = await list();
// TODO: This ends up restarting apps that have optional redis
apps = apps.filter(app => app.manifest.addons && _.intersection(Object.keys(app.manifest.addons), changedAddons).length !== 0);
apps = apps.filter(app => app.installationState !== exports.ISTATE_ERROR); // remove errored apps. let them be 'repaired' by hand
apps = apps.filter(app => app.installationState !== exports.ISTATE_PENDING_RESTART); // safeguard against tasks being created non-stop restart if we crash on startup