jjkiers/OAuth
1
0
Fork 0
Code Issues 2 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Add load balancer support #5

Open
brutuscat wants to merge 1 commits from brutuscat/load-balancer-forwarded-headers into master
pull from: brutuscat/load-balancer-forwarded-headers
merge into: jjkiers:master
Conversation 3 Commits 1 Files Changed 1 +8 -1
brutuscat commented 2014-10-16 09:39:14 +00:00 (Migrated from github.com)
Copy Link

Add load balancer support using non-standard X-Forwarded headers.

Basically it adds support for AWS Elastic Load Balancer. See docs here x-forwarded-headers and a proposed standard rfc7239 which varies a bit since it does not seem to add support for the X-Forwarded-Port header.

I also confirm that this does work behind a ELB that does SSL termination.

Add load balancer support using non-standard X-Forwarded headers. Basically it adds support for AWS Elastic Load Balancer. See docs here [x-forwarded-headers](https://docs.aws.amazon.com/ElasticLoadBalancing/latest/DeveloperGuide/TerminologyandKeyConcepts.html#x-forwarded-headers) and a proposed standard [rfc7239](http://tools.ietf.org/html/rfc7239) which varies a bit since it does not seem to add support for the `X-Forwarded-Port` header. I also confirm that this does work behind a ELB that does SSL termination.
jacobkiers commented 2014-10-16 15:55:55 +00:00 (Migrated from github.com)
Copy Link

Hi, thank you for your contribution! I'm very busy at the moment, so I'll look at it during the weekend.

Hi, thank you for your contribution! I'm very busy at the moment, so I'll look at it during the weekend.
jacobkiers commented 2014-11-10 12:55:43 +00:00 (Migrated from github.com)
Copy Link

@brutuscat I'm sorry, I kind of forgot about this PR. Are you still interested in this?

If so, please add tests and then I'll merge it.

@brutuscat I'm sorry, I kind of forgot about this PR. Are you still interested in this? If so, please add tests and then I'll merge it.
brutuscat commented 2014-11-10 15:52:26 +00:00 (Migrated from github.com)
Copy Link

@jacobkiers I have it working just fine in my fork, so yes I'm interested as anyone who is behind a load balancer will be too I guess... You might also want to add support for this too http://tools.ietf.org/html/rfc7239

@jacobkiers I have it working just fine in my fork, so yes I'm interested as anyone who is behind a load balancer will be too I guess... You might also want to add support for this too http://tools.ietf.org/html/rfc7239
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin brutuscat/load-balancer-forwarded-headers:brutuscat/load-balancer-forwarded-headers
git checkout brutuscat/load-balancer-forwarded-headers
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jjkiers/OAuth#5
No description provided.
Delete Branch "brutuscat/load-balancer-forwarded-headers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?