jjkiers
/
OAuth
1
0
Fork 0
Code Issues 2 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

oauth_version parameter should be optional #3

Merged
vimishor merged 1 commits from bug/version-optional into master 2014-02-21 17:41:04 +00:00
Conversation 4 Commits 1 Files Changed 1 -1
vimishor commented 2014-02-17 13:45:46 +00:00 (Migrated from github.com)
Copy Link

oauth_version parameter should be optional.

@see: http://oauth.net/core/1.0a/#rfc.section.6.1.1 and http://oauth.net/core/1.0a/#rfc.section.6.3.1

`oauth_version` parameter should be optional. @see: http://oauth.net/core/1.0a/#rfc.section.6.1.1 and http://oauth.net/core/1.0a/#rfc.section.6.3.1
vimishor commented 2014-02-19 07:04:46 +00:00 (Migrated from github.com)
Copy Link

Ping @jacobkiers

Ping @jacobkiers
jacobkiers commented 2014-02-21 17:01:47 +00:00 (Migrated from github.com)
Copy Link

Hi @vimishor, thanks for the patch. Have you tested it with the server implementation?

I've been abroad for the past week, that's why it took a while.

Hi @vimishor, thanks for the patch. Have you tested it with the server implementation? I've been abroad for the past week, that's why it took a while.
vimishor commented 2014-02-21 17:08:35 +00:00 (Migrated from github.com)
Copy Link

It looks like the server respects the spec. ref

It looks like the server respects the spec. [ref](https://github.com/jacobkiers/OAuth/blob/da8c3c46c5beca8b1cea4aab523fd196fdc1c308/src/JacobKiers/OAuth/Server.php#L165-L169)
jacobkiers commented 2014-02-21 17:41:37 +00:00 (Migrated from github.com)
Copy Link

Merged and tagged. Thanks.

Merged and tagged. Thanks.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jjkiers/OAuth#3
No description provided.
Delete Branch "bug/version-optional"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?