Added CONTRIBUTORS.md file.

Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>
Because $token refs an object, this statement will always be true. Therefore an empty oauth_token param will be added to each request, wich will break Bitbucket authorization process.
2013-06-06 05:58:53 +02:00 · 2013-06-06 05:58:53 +02:00
2 changed files with 10 additions and 1 deletions
--- a/CONTRIBUTORS.md
+++ b/CONTRIBUTORS.md
@@ -0,0 +1,9 @@
+This project has had multiple authors. In this file, I will try to credit
+each of them. If you are not listed for some reason, please ask.
+
+Andy Smith authored the original code (http://oauth.googlecode.com/svn/code/php/).
+
+ * Alexandre Eher (@EHER)
+ * Gary Jones (@GaryJones)
+ * Jacob Kiers (@jacobkiers)
+ * Alexandru G. (@vimishor)
--- a/src/JacobKiers/OAuth/Request/Request.php
+++ b/src/JacobKiers/OAuth/Request/Request.php
@@ -157,7 +157,7 @@ public static function fromConsumerAndToken(
            'oauth_nonce' => Request::generateNonce(),
            'oauth_timestamp' => Request::generateTimestamp(),
            'oauth_consumer_key' => $consumer->getKey());
-        if ($token) {
+        if ($token->getKey()) {
            $defaults['oauth_token'] = $token->getKey();
        }
Author	SHA1	Message	Date
Jacob Kiers	b3d4f9b6bc	Added CONTRIBUTORS.md file. Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>	2013-06-06 05:58:53 +02:00
Alexandru G	087cb1278f	Because `$token` refs an object, this statement will always be true. Therefore an empty `oauth_token` param will be added to each request, wich will break Bitbucket authorization process. To fix this, we need to check if token key is empty and ignore it.	2013-06-06 05:58:53 +02:00