Girish Ramakrishnan
|
4ed6fbbd74
|
eslint: add no-shadow
|
2026-02-18 08:18:37 +01:00 |
|
Girish Ramakrishnan
|
36aa641cb9
|
migrate to "export default"
also, set no-use-before-define in linter
|
2026-02-14 15:43:24 +01:00 |
|
Girish Ramakrishnan
|
96dc79cfe6
|
Migrate codebase from CommonJS to ES Modules
- Convert all require()/module.exports to import/export across 260+ files
- Add "type": "module" to package.json to enable ESM by default
- Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible
- Convert eslint.config.js to ESM with sourceType: "module"
- Replace __dirname/__filename with import.meta.dirname/import.meta.filename
- Replace require.main === module with process.argv[1] === import.meta.filename
- Remove 'use strict' directives (implicit in ESM)
- Convert dynamic require() in switch statements to static import lookup maps
(dns.js, domains.js, backupformats.js, backupsites.js, network.js)
- Extract self-referencing exports.CONSTANT patterns into standalone const
declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.)
- Lazify SERVICES object in services.js to avoid circular dependency TDZ issues
- Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests
- Add _setMockApp() to ldapserver.js for ESM-safe test mocking
- Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests
- Convert backupupload.js to use dynamic imports so --check exits before
loading the module graph (which requires BOX_ENV)
- Update check-install to use ESM import for infra_version.js
- Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations)
- All 1315 tests passing
Migration stats (AI-assisted using Cursor with Claude):
- Wall clock time: ~3-4 hours
- Assistant completions: ~80-100
- Estimated token usage: ~1-2M tokens
Co-authored-by: Cursor <cursoragent@cursor.com>
|
2026-02-14 15:11:45 +01:00 |
|
Girish Ramakrishnan
|
12e073e8cf
|
use node: prefix for requires
mostly because code is being autogenerated by all the AI stuff using
this prefix. it's also used in the stack trace.
|
2025-08-14 12:55:35 +05:30 |
|
Girish Ramakrishnan
|
bba48f455e
|
use @connect-lastmile
|
2025-07-10 11:00:31 +02:00 |
|
Girish Ramakrishnan
|
40631a753f
|
Fix express 5 crashes
|
2025-06-06 16:23:07 +02:00 |
|
Johannes Zellner
|
11c64f3035
|
http reqs still have statusCode
|
2025-02-17 14:26:17 +01:00 |
|
Girish Ramakrishnan
|
8e58349bfa
|
replace with custom superagent based on fetch API
|
2025-02-15 15:14:09 +01:00 |
|
Girish Ramakrishnan
|
2ff995aa95
|
filemanager: do not respond again
|
2024-08-08 15:20:50 +02:00 |
|
Girish Ramakrishnan
|
b870f98ec2
|
proxy-middleware: no more a middleware
|
2024-07-30 13:34:41 +02:00 |
|
Girish Ramakrishnan
|
a5249102f2
|
proxy-middleware: just pass a string
|
2024-07-30 12:04:35 +02:00 |
|
Girish Ramakrishnan
|
d8aa4bc5e4
|
filemanager: fix sending of double header
we should not proceed to notFoundHandler if proxy handled it just fine
|
2024-07-26 11:58:41 +02:00 |
|
Johannes Zellner
|
a6369a7dde
|
Fix linter error
|
2024-07-19 22:24:34 +02:00 |
|
Girish Ramakrishnan
|
5e9a46d71e
|
filemanager: fix mounting of filesystem and mountpoint backends
|
2021-12-24 15:05:51 -08:00 |
|
Girish Ramakrishnan
|
8255623874
|
mail: mount mail data directory into sftp container
fixes #794
|
2021-09-26 13:47:45 -07:00 |
|
Girish Ramakrishnan
|
d4edd771b5
|
sftp: prefix the id with app- and volume-
this helps the backend identify the type of mount
|
2021-09-25 23:35:44 -07:00 |
|
Girish Ramakrishnan
|
42774eac8c
|
docker.js and services.js: async'ify
|
2021-08-26 18:23:31 -07:00 |
|
Girish Ramakrishnan
|
6bd87485c6
|
rename addons.js to services.js
services is the named container (services view)
addons is more like a heroku concept
|
2021-01-21 11:31:35 -08:00 |
|
Johannes Zellner
|
e77201099d
|
Encode filemanager route paths correctly and do not expect starts with /
|
2020-11-04 13:58:53 +01:00 |
|
Girish Ramakrishnan
|
9615dc1458
|
Mount volumes into the file browser
|
2020-10-30 11:05:47 -07:00 |
|
Girish Ramakrishnan
|
9d1bb29a00
|
sftp: Make extract work
|
2020-10-19 19:58:39 -07:00 |
|
Girish Ramakrishnan
|
876d0d5873
|
sftp: init and access API with a token
|
2020-10-19 19:13:54 -07:00 |
|
Johannes Zellner
|
0a7b132be8
|
Remove or increase timeouts for filemanager
|
2020-07-13 17:05:22 +02:00 |
|
Johannes Zellner
|
ba50eb121d
|
Use new sftp addon
|
2020-07-10 14:13:16 +02:00 |
|