36aa641cb9
migrate to "export default"
...
also, set no-use-before-define in linter
2026-02-14 15:43:24 +01:00
96dc79cfe6
Migrate codebase from CommonJS to ES Modules
...
- Convert all require()/module.exports to import/export across 260+ files
- Add "type": "module" to package.json to enable ESM by default
- Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible
- Convert eslint.config.js to ESM with sourceType: "module"
- Replace __dirname/__filename with import.meta.dirname/import.meta.filename
- Replace require.main === module with process.argv[1] === import.meta.filename
- Remove 'use strict' directives (implicit in ESM)
- Convert dynamic require() in switch statements to static import lookup maps
(dns.js, domains.js, backupformats.js, backupsites.js, network.js)
- Extract self-referencing exports.CONSTANT patterns into standalone const
declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.)
- Lazify SERVICES object in services.js to avoid circular dependency TDZ issues
- Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests
- Add _setMockApp() to ldapserver.js for ESM-safe test mocking
- Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests
- Convert backupupload.js to use dynamic imports so --check exits before
loading the module graph (which requires BOX_ENV)
- Update check-install to use ESM import for infra_version.js
- Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations)
- All 1315 tests passing
Migration stats (AI-assisted using Cursor with Claude):
- Wall clock time: ~3-4 hours
- Assistant completions: ~80-100
- Estimated token usage: ~1-2M tokens
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-02-14 15:11:45 +01:00
43e426ab9f
Revert "Add no-use-before-define linter rule"
...
This reverts commit fdcc5d68a2
2025-10-08 21:17:52 +02:00
12e073e8cf
use node: prefix for requires
...
mostly because code is being autogenerated by all the AI stuff using
this prefix. it's also used in the stack trace.
2025-08-14 12:55:35 +05:30
618d2b993a
apphealth: print healthcheck exceptions
2025-08-06 08:26:08 +02:00
6ac0cd421a
use the @cloudron/superagent module
2025-07-10 10:56:05 +02:00
f82f3fa858
Fix long standing Healthcheck typo
2025-04-02 11:47:16 +02:00
8e58349bfa
replace with custom superagent based on fetch API
2025-02-15 15:14:09 +01:00
ff5dccc2b4
remove obsolete comment
2024-10-12 10:50:58 +02:00
50a069a7fa
apphealthmonitor: only treat 5xx codes as truly erroneous
2024-02-28 17:39:08 +01:00
d2c702f890
eventlog: always use AuditSource objects as source field
2023-08-28 08:13:56 +05:30
6259849958
apphealth: timeout is already in msecs
2023-06-22 18:24:59 +05:30
c4f4f3e914
logs: use %o to format error
...
otherwise, they are printed as multi-line and this messes up tail+date formatting
2023-04-16 10:49:59 +02:00
2a660fa59d
change terminology to running and unresponsive
2022-11-30 14:41:48 +01:00
e942b8fe7e
better debugs
2022-11-30 13:08:05 +01:00
84ba333aa1
app proxy: disable TLS check in app health monitor
2022-10-01 11:47:52 +02:00
9bd9b72e5d
apphealthmonitor: Fix crash
2022-06-10 11:09:41 -07:00
f382b8f1f5
Set real upstreamUri for healthcheck
2022-06-09 15:04:09 +02:00
fbc7fcf04b
Put healthcheck errors in app logs
2022-06-09 14:56:40 +02:00
923a9f6560
Rename RELAY_APPSTORE_ID to PROXY_APP_APPSTORE_ID
2022-06-09 13:57:57 +02:00
a955457ee7
Support proxy app
2022-06-09 10:48:54 +02:00
a3e097d541
add missing awaits for eventlog.add
2022-02-24 20:04:46 -08:00
8cda287838
fix crash when there are multiple quick oom events
2021-10-19 12:25:25 -07:00
445c83c8b9
make auditsource a class
...
this allows us to use AuditSource for the class and auditSource for
the instances!
2021-09-30 10:13:36 -07:00
50c68cd499
notifications: better oom message for redis
...
fixes #795
2021-09-19 17:34:41 -07:00
42774eac8c
docker.js and services.js: async'ify
2021-08-26 18:23:31 -07:00
77f5cb183b
merge appdb.js into apps.js
2021-08-23 15:35:38 -07:00
ebab671f68
remove slash from container name
2021-06-23 17:20:11 -07:00
8da4eaf4a3
fix tests
2021-06-03 16:08:39 -07:00
73917e95c9
rework notifications
...
notifications are now system level instead of user level.
To clarify the use events/notifications/email:
* eventlog - everything that is happenning on server
* notifications - specific important events (alerts)
* email - these are really urgent things that require immediate attention. this is for
the case where an admin does not visit the dashboard often. can also be alerts like
bad backup config or reboot required which are not events per-se.
Notes on notifications
* oom - notification only
* appUpdated - notification only
* cert renewal failure - only raise when < 10 days to go. also send email thereafter (todo).
* Backup failure - only if last 5 backups failed (todo).
* Box update - notification only. we anyway send newsletter.
* box update available - we raise a notification. no email.
* app update available - we already have update indicator on dashboard. so, no notification or email.
Alerts:
* backup config
* disk space
* mail status
* reboot
* box updated
* ubuntu update required
2021-05-28 15:29:53 -07:00
f211de1ff4
apphealthmonitor: 403 is ok
2021-03-30 11:57:30 -07:00
1724607433
apphealth: clamp health time to first run
...
the platform.start can take forever. this means that we start the
clock to include platform.start and this sends a lot of spurious
up/down notifications.
also, bump the down threshold to 20 mins.
2021-03-04 15:03:08 -08:00
10ca889de0
apphealthmonitor: better debugs
2021-03-04 11:42:43 -08:00
aedc8e8087
do not send flurry of down notification on box restart
2021-01-16 11:27:19 -08:00
294413b798
Fix comment
2021-01-02 12:12:08 -08:00
c0b0029935
statically allocate app container IPs
...
We removed httpPort with the assumption that docker allocated IPs
and kept them as long as the container is around. This turned out
to be not true because the IP changes on even container restart.
So we now allocate IPs statically. The iprange makes sure we don't
overlap with addons and other CI app or JupyterHub apps.
https://github.com/moby/moby/issues/6743
https://github.com/moby/moby/pull/19001
2020-11-20 16:19:59 -08:00
d703d1cd13
remove httpPort
...
we can just use container IP instead of all this httpPort exporting magic.
this is also required for exposing httpPaths feature (we have to otherwise
have multiple httpPorts).
2020-11-19 00:38:52 -08:00
86916a94de
allow 401 and 403 errors to pass health check
...
way too many WP sites use some plugin to block health check routes.
maybe some day we will have dynamic health check route settable by user.
2020-11-10 16:50:36 -08:00
f2489c0845
some logs for tracking the cron issue
2020-10-07 14:47:51 -07:00
252aedda25
remove verbose logs
2020-08-18 12:46:55 -07:00
50dcf827a5
remove console.error use in many places
...
the backtraces just flood the logs
apphealthtask: remove console.error
remove spurious console.dir
cleanup scheduler error logging
2020-06-04 11:21:56 -07:00
d2cd78c5cb
more debug() removal
2020-05-24 12:30:48 -07:00
d000719fa2
app health monitor is too verbose
2020-05-24 11:43:17 -07:00
1ad0cff28e
Use app.fqdn in output
2019-12-24 11:07:53 -08:00
d255466417
manifest.id is optional for custom apps
2019-11-15 17:28:54 -08:00
a017af41c5
Start moving db code to use BoxError as well
2019-10-24 14:09:53 -07:00
dd0fb8292c
Move state enums to the model code
2019-08-30 13:21:51 -07:00
e29d224a92
Be a bit more specific
2019-07-31 15:45:25 -07:00
bb48ffb01f
Fixup UA for easier detection (other than IP)
2019-07-31 15:43:15 -07:00
d752c68790
re-factor all the audit source objects
2019-03-25 15:15:39 -07:00
Girish Ramakrishnan