 Girish Ramakrishnan
|
96dc79cfe6
|
Migrate codebase from CommonJS to ES Modules
- Convert all require()/module.exports to import/export across 260+ files
- Add "type": "module" to package.json to enable ESM by default
- Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible
- Convert eslint.config.js to ESM with sourceType: "module"
- Replace __dirname/__filename with import.meta.dirname/import.meta.filename
- Replace require.main === module with process.argv[1] === import.meta.filename
- Remove 'use strict' directives (implicit in ESM)
- Convert dynamic require() in switch statements to static import lookup maps
(dns.js, domains.js, backupformats.js, backupsites.js, network.js)
- Extract self-referencing exports.CONSTANT patterns into standalone const
declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.)
- Lazify SERVICES object in services.js to avoid circular dependency TDZ issues
- Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests
- Add _setMockApp() to ldapserver.js for ESM-safe test mocking
- Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests
- Convert backupupload.js to use dynamic imports so --check exits before
loading the module graph (which requires BOX_ENV)
- Update check-install to use ESM import for infra_version.js
- Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations)
- All 1315 tests passing
Migration stats (AI-assisted using Cursor with Claude):
- Wall clock time: ~3-4 hours
- Assistant completions: ~80-100
- Estimated token usage: ~1-2M tokens
Co-authored-by: Cursor <cursoragent@cursor.com>
|
2026-02-14 15:11:45 +01:00 |
|
|
Girish Ramakrishnan
|
dd5e4adc73
|
replace underscore with our own
we only need like 5 simple functions
|
2025-02-13 14:14:34 +01:00 |
|
|
Girish Ramakrishnan
|
7322006455
|
test: fix route53 tests
|
2025-02-11 11:29:43 +01:00 |
|
|
Girish Ramakrishnan
|
aa54e47029
|
tests: enable nock when needed
by default, it makes all requests disappear
|
2025-02-05 18:27:57 +01:00 |
|
|
Girish Ramakrishnan
|
d58789cc25
|
test: more test fixing
|
2024-10-14 18:37:22 +02:00 |
|
|
Girish Ramakrishnan
|
e42579521c
|
Fix tests
|
2024-01-03 15:12:07 +01:00 |
|
|
Girish Ramakrishnan
|
e097b79f65
|
godaddy: do not remove all the records of type
|
2022-04-28 17:46:03 -07:00 |
|
|
Girish Ramakrishnan
|
f7ed044a40
|
fix storage test
|
2022-04-15 07:49:38 -05:00 |
|
|
Girish Ramakrishnan
|
91dc91a390
|
fix dns tests
|
2022-02-18 11:36:14 -08:00 |
|
|
Girish Ramakrishnan
|
39807e6ba4
|
domain: split the config and wellknown routes
we want to add more stuff to the UI like the jitsi URL
|
2021-12-03 18:14:46 -08:00 |
|
|
Girish Ramakrishnan
|
51d067cbe3
|
sysinfo: async'ify
in the process, provision, dyndns, mail, dns also got further asyncified
|
2021-09-02 16:19:46 -07:00 |
|
|
Girish Ramakrishnan
|
5bcf1bc47b
|
merge domaindb.js into domains.js
|
2021-08-16 14:41:42 -07:00 |
|