No need to return args as part of task.get

This reverts commit 831e22b4ff.
This reverts commit 6774514bd2.
This commit is contained in:
Girish Ramakrishnan
2019-12-06 08:40:16 -08:00
parent 2ffb32ae60
commit ffeb484a10
4 changed files with 14 additions and 3 deletions
+3 -1
View File
@@ -31,7 +31,7 @@ function get(req, res, next) {
tasks.get(req.params.taskId, function (error, task) {
if (error) return next(BoxError.toHttpError(error));
next(new HttpSuccess(200, task));
next(new HttpSuccess(200, tasks.removePrivateFields(task)));
});
}
@@ -47,6 +47,8 @@ function list(req, res, next) {
tasks.listByTypePaged(req.query.type || null, page, perPage, function (error, result) {
if (error) return next(BoxError.toHttpError(error));
result = result.map(tasks.removePrivateFields);
next(new HttpSuccess(200, { tasks: result }));
});
}
+2 -2
View File
@@ -62,7 +62,7 @@ describe('Tasks API', function () {
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.percent).to.be(100);
expect(res.body.args).to.eql(['ping']);
expect(res.body.args).to.be(undefined);
expect(res.body.active).to.be(false); // finished
expect(res.body.success).to.be(true);
expect(res.body.result).to.be('ping');
@@ -144,7 +144,7 @@ describe('Tasks API', function () {
expect(res.body.tasks.length >= 1).to.be(true);
expect(res.body.tasks[0].id).to.be(taskId);
expect(res.body.tasks[0].percent).to.be(100);
expect(res.body.tasks[0].args).to.eql(['ping']);
expect(res.body.tasks[0].args).to.be(undefined);
expect(res.body.tasks[0].active).to.be(false); // finished
expect(res.body.tasks[0].success).to.be(true); // finished
expect(res.body.tasks[0].result).to.be('ping');