add mailboxes tests

src/mailboxes.js

@@ -4,7 +4,9 @@ exports = module.exports = {
     add: add,
     del: del,
     get: get,
-    getAll: getAll
+    getAll: getAll,
+
+    MailboxError: MailboxError
 };
 
 var assert = require('assert'),
@@ -33,9 +35,18 @@ function MailboxError(reason, errorOrMessage) {
 util.inherits(MailboxError, Error);
 MailboxError.ALREADY_EXISTS = 'already exists';
 MailboxError.BAD_NAME = 'bad name';
+MailboxError.NOT_FOUND = 'not found';
 MailboxError.INTERNAL_ERROR = 'internal error';
 
 function validateName(name) {
+    var RESERVED_NAMES = [ 'no-reply', 'postmaster', 'mailer-daemon' ];
+
+    if (name.length < 2) return new MailboxError(MailboxError.BAD_NAME, 'Name too small');
+    if (name.length > 127) return new MailboxError(MailboxError.BAD_NAME, 'Name too long');
+    if (RESERVED_NAMES.indexOf(name) !== -1) return new MailboxError(MailboxError.BAD_NAME, 'Name is reserved');
+
+    if (/[^a-zA-Z0-9.]/.test(name)) return new MailboxError(MailboxError.BAD_NAME, 'Name can only contain alphanumerals and dot');
+
     return null;
 }
 
@@ -43,11 +54,13 @@ function add(name, callback) {
     assert.strictEqual(typeof name, 'string');
     assert.strictEqual(typeof callback, 'function');
 
+    name = name.toLowerCase();
+
     var error = validateName(name);
     if (error) return callback(error);
 
     mailboxdb.add(name /* id */, name, function (error) {
-        if (error && error.reason === MailboxError.ALREADY_EXISTS) return callback(new MailboxError(MailboxError.ALREADY_EXISTS));
+        if (error && error.reason === DatabaseError.ALREADY_EXISTS) return callback(new MailboxError(MailboxError.ALREADY_EXISTS));
         if (error) return callback(new MailboxError(MailboxError.INTERNAL_ERROR, error));
 
         var mailbox = {
@@ -60,10 +73,11 @@ function add(name, callback) {
 }
 
 function del(id, callback) {
-    assert.strictEqual(typeof name, 'string');
+    assert.strictEqual(typeof id, 'string');
     assert.strictEqual(typeof callback, 'function');
 
-    mailboxdb.del(name, function (error) {
+    mailboxdb.del(id, function (error) {
+        if (error && error.reason === DatabaseError.NOT_FOUND) return callback(new MailboxError(MailboxError.NOT_FOUND));
         if (error) return callback(new MailboxError(MailboxError.INTERNAL_ERROR, error));
 
         callback();
@@ -75,6 +89,7 @@ function get(id, callback) {
     assert.strictEqual(typeof callback, 'function');
 
     mailboxdb.get(id, function (error, mailbox) {
+        if (error && error.reason === DatabaseError.NOT_FOUND) return callback(new MailboxError(MailboxError.NOT_FOUND));
         if (error) return callback(new MailboxError(MailboxError.INTERNAL_ERROR, error));
 
         callback(null, mailbox);