storage: remove usage of secret placeholder

src/storage/s3.js

@@ -1,32 +1,5 @@
 'use strict';
 
-exports = module.exports = {
-    setup,
-    teardown,
-    cleanup,
-
-    verifyConfig,
-    removePrivateFields,
-    injectPrivateFields,
-
-    getAvailableSize,
-    getStatus,
-
-    upload,
-    exists,
-    download,
-    copy,
-    copyDir,
-
-    listDir,
-
-    remove,
-    removeDir,
-
-    // Used to mock AWS
-    _chunk: chunk
-};
-
 const assert = require('node:assert'),
     async = require('async'),
     BoxError = require('../boxerror.js'),
@@ -679,12 +652,39 @@ async function teardown(apiConfig) {
 }
 
 function removePrivateFields(apiConfig) {
-    apiConfig.secretAccessKey = constants.SECRET_PLACEHOLDER;
+    delete apiConfig.secretAccessKey;
     delete apiConfig._provider;
     return apiConfig;
 }
 
 function injectPrivateFields(newConfig, currentConfig) {
-    if (newConfig.secretAccessKey === constants.SECRET_PLACEHOLDER) newConfig.secretAccessKey = currentConfig.secretAccessKey;
+    if (!Object.hasOwn(newConfig, 'secretAccessKey')) newConfig.secretAccessKey = currentConfig.secretAccessKey;
     newConfig._provider = currentConfig._provider;
 }
+
+exports = module.exports = {
+    setup,
+    teardown,
+    cleanup,
+
+    verifyConfig,
+    removePrivateFields,
+    injectPrivateFields,
+
+    getAvailableSize,
+    getStatus,
+
+    upload,
+    exists,
+    download,
+    copy,
+    copyDir,
+
+    listDir,
+
+    remove,
+    removeDir,
+
+    // Used to mock AWS
+    _chunk: chunk
+};