diff --git a/migrations/20240501100302-settings-remove-backup-storage-limit.js b/migrations/20240501100302-settings-remove-backup-storage-limit.js new file mode 100644 index 000000000..20813ea1e --- /dev/null +++ b/migrations/20240501100302-settings-remove-backup-storage-limit.js @@ -0,0 +1,14 @@ +'use strict'; + +exports.up = async function(db) { + const result = await db.runSql('SELECT * FROM settings WHERE name=?', [ 'backup_storage' ]); + if (!result.length) return; + + const storageConfig = JSON.parse(result[0].value); + delete storageConfig.limits; // this is already saved in backup_limits key + await db.runSql('UPDATE settings SET value=? WHERE name=?', [ JSON.stringify(storageConfig), 'backup_storage']); +}; + +exports.down = async function(/* db */) { +}; + diff --git a/src/backups.js b/src/backups.js index 09802d1cb..db25a2aa0 100644 --- a/src/backups.js +++ b/src/backups.js @@ -238,7 +238,7 @@ async function setState(id, state) { } async function startBackupTask(auditSource) { - let error = locker.lock(locker.OP_FULL_BACKUP); + const error = locker.lock(locker.OP_FULL_BACKUP); if (error) throw new BoxError(BoxError.BAD_STATE, `Cannot backup now: ${error.message}`); const backupConfig = await getConfig();