jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

tests: complete common'ification of routes tests

Browse Source
This commit is contained in:
Girish Ramakrishnan
2021-08-12 21:24:18 -07:00
parent ac5b7f8093
commit ec0d64ac12
3 changed files with 182 additions and 338 deletions
Download Patch File Download Diff File Expand all files Collapse all files

115
src/routes/test/backups-test.js
View File

@@ -5,107 +5,44 @@
'use strict';
const appdb = require('../../appdb.js'),
async = require('async'),
constants = require('../../constants.js'),
database = require('../../database.js'),
domains = require('../../domains.js'),
const common = require('./common.js'),
expect = require('expect.js'),
nock = require('nock'),
superagent = require('superagent'),
server = require('../../server.js'),
settings = require('../../settings.js');
const SERVER_URL = 'http://localhost:' + constants.PORT;
const USERNAME = 'superadmin', PASSWORD = 'Foobar?1337', EMAIL ='silly@me.com';
const DOMAIN_0 = {
domain: 'example-backups-test.com',
zoneName: 'example-backups-test.com',
config: {},
provider: 'noop',
fallbackCertificate: null,
tlsConfig: { provider: 'fallback' }
};
let AUDIT_SOURCE = { ip: '1.2.3.4' };
var token = null;
function setup(done) {
nock.cleanAll();
async.series([
server.start,
database._clear,
domains.add.bind(null, DOMAIN_0.domain, DOMAIN_0, AUDIT_SOURCE),
function createAdmin(callback) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: USERNAME, password: PASSWORD, email: EMAIL })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(201);
// stash token for further use
token = result.body.token;
callback();
});
},
function addApp(callback) {
var manifest = { version: '0.0.1', manifestVersion: 1, dockerImage: 'foo', healthCheckPath: '/', httpPort: 3, title: 'ok', addons: { } };
appdb.add('appid', 'appStoreId', manifest, 'location', DOMAIN_0.domain, [ ] /* portBindings */, { installationState: 'installed', runState: 'running', mailboxDomain: DOMAIN_0.domain }, callback);
},
function createSettings(callback) {
settings.setBackupConfig({ provider: 'filesystem', backupFolder: '/tmp', format: 'tgz', retentionPolicy: { keepWithinSecs: 2 * 24 * 60 * 60 }, schedulePattern: '00 00 23 * * *' }, callback);
}
], done);
}
function cleanup(done) {
database._clear(function (error) {
expect(!error).to.be.ok();
server.stop(done);
});
}
superagent = require('superagent');
describe('Backups API', function () {
before(setup);
const { setup, cleanup, serverUrl, owner } = common;
before(setup);
after(cleanup);
describe('create', function () {
it('fails due to mising token', function (done) {
superagent.post(SERVER_URL + '/api/v1/backups/create')
.end(function (error, result) {
expect(result.statusCode).to.equal(401);
done();
});
it('fails due to mising token', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/backups/create`)
.ok(() => true);
expect(response.statusCode).to.equal(401);
});
it('fails due to wrong token', function (done) {
superagent.post(SERVER_URL + '/api/v1/backups/create')
.query({ access_token: token.toUpperCase() })
.end(function (error, result) {
expect(result.statusCode).to.equal(401);
done();
});
it('fails due to wrong token', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/backups/create`)
.query({ access_token: 'randomtoken' })
.ok(() => true);
expect(response.statusCode).to.equal(401);
});
it('succeeds', function (done) {
superagent.post(SERVER_URL + '/api/v1/backups/create')
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(202);
it('succeeds', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/backups/create`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(202);
expect(response.body.taskId).to.be.a('string');
});
});
done();
});
describe('list', function () {
it('succeeds', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/backups`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.backups).to.be.an('array');
});
});
});

17
src/routes/test/common.js
View File

@@ -16,6 +16,7 @@ const async = require('async'),
exports = module.exports = {
setup,
setupServer,
cleanup,
clearMailQueue,
checkMails,
@@ -25,6 +26,7 @@ exports = module.exports = {
username: 'superadmin',
password: 'Foobar?1337',
email: 'superadmin@cloudron.local',
displayName: 'Super Admin',
token: null
},
@@ -44,17 +46,20 @@ exports = module.exports = {
serverUrl: `http://localhost:${constants.PORT}`,
};
function setupServer(done) {
async.series([
server.start.bind(null),
database._clear.bind(null),
settings._setApiServerOrigin.bind(null, exports.mockApiServerOrigin),
], done);
}
function setup(done) {
const owner = exports.owner, serverUrl = exports.serverUrl, user = exports.user;
async.series([
server.start.bind(null),
database._clear.bind(null),
setupServer,
async () => await safe(fs.promises.unlink(support._sshInfo().filePath)),
settings._setApiServerOrigin.bind(null, exports.mockApiServerOrigin),
settings.setCloudronToken.bind(null, exports.appstoreToken),
function setup(callback) {

388
src/routes/test/provision-test.js
View File

@@ -5,332 +5,234 @@
/* global before:false */
/* global after:false */
const async = require('async'),
constants = require('../../constants.js'),
database = require('../../database.js'),
const common = require('./common.js');
const delay = require('delay'),
expect = require('expect.js'),
nock = require('nock'),
server = require('../../server.js'),
superagent = require('superagent'),
settings = require('../../settings.js');
superagent = require('superagent');
const DOMAIN = 'example-server-test.com';
const USERNAME = 'superadmin', PASSWORD = 'Foobar?1337', EMAIL ='silly@me.com';
const SERVER_URL = 'http://localhost:' + constants.PORT;
function waitForSetup(done) {
async.retry({ times: 5, interval: 4000 }, function (retryCallback) {
superagent.get(SERVER_URL + '/api/v1/cloudron/status')
.end(function (error, result) {
if (!result || result.statusCode !== 200) return retryCallback(new Error('Bad result'));
if (!result.body.setup.active && result.body.setup.errorMessage === '' && result.body.adminFqdn) return retryCallback();
retryCallback(new Error('Not done yet: ' + JSON.stringify(result.body)));
});
}, done);
}
describe('Provision', function () {
before(function (done) {
nock.cleanAll();
const { setupServer, cleanup, serverUrl, owner } = common;
async.series([
server.start.bind(server),
database._clear,
settings._setApiServerOrigin.bind(null, 'http://localhost:6060'),
settings.setBackupConfig.bind(null, { provider: 'filesystem', backupFolder: '/tmp', format: 'tgz', retentionPolicy: { keepWithinSecs: 10000 }, schedulePattern: '00 00 23 * * *' })
], done);
});
before(setupServer);
after(cleanup);
after(function (done) {
database._clear(function (error) {
expect(error).to.not.be.ok();
async function waitForSetup() {
for (let times = 0; times < 5; ++times) {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/status`)
.ok(() => true);
server.stop(done);
});
});
if (response.statusCode === 200 && !response.body.setup.active && response.body.setup.errorMessage === '' && response.body.adminFqdn) return;
describe('DNS Setup', function () {
it('dns setup fails without provider', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
await delay(4000);
}
throw new Error('Setup did not complete');
}
describe('DNS Setup', async function () {
it('fails without provider', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { domain: DOMAIN, config: {} } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('dns setup fails with invalid provider', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
it('fails with invalid provider', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'foobar', domain: DOMAIN, config: {} } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('dns setup fails with missing domain', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
it('fails with missing domain', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', config: {} } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('dns setup fails with invalid domain', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
it('fails with invalid domain', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', domain: '.foo', config: {} } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('dns setup fails with invalid config', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
it('fails with invalid config', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, config: 'not an object' } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('dns setup fails with invalid zoneName', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
it('fails with invalid zoneName', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, config: {}, zoneName: 1337 } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('dns setup fails with invalid tlsConfig', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
it('fails with invalid tlsConfig', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, config: {}, tlsConfig: 'foobar' } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('dns setup fails with invalid tlsConfig provider', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
it('fails with invalid tlsConfig provider', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, config: {}, tlsConfig: { provider: 1337 } } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('dns setup succeeds', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
it('succeeds', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, adminFqdn: 'my.' + DOMAIN, config: {}, tlsConfig: { provider: 'fallback' } } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(200);
.ok(() => true);
waitForSetup(done);
});
expect(response.statusCode).to.eql(200);
await waitForSetup();
});
xit('dns setup twice succeeds', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, DOMAIN, config: {} }, tlsConfig: { provider: 'fallback' } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(200);
it('twice succeeds', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, adminFqdn: 'my.' + DOMAIN, config: {}, tlsConfig: { provider: 'fallback' } } })
.ok(() => true);
waitForSetup(done);
});
expect(response.statusCode).to.eql(200);
await waitForSetup();
});
});
describe('Activation', function () {
it('device is in first time mode', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/status')
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.activated).to.not.be.ok();
done(err);
});
it('device is in first time mode', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/status`);
expect(response.statusCode).to.equal(200);
expect(response.body.activated).to.not.be.ok();
});
it('activation fails without username', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ password: PASSWORD, email: EMAIL })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
it('fails without username', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ password: owner.password, email: owner.email })
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('activation fails with invalid username', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: '?this.is-not!valid', password: PASSWORD, email: EMAIL })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
it('fails with invalid username', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: '?this.is-not!valid', password: owner.password, email: owner.email })
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('fails due to empty username', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: '', password: 'ADSFsdf$%436', email: 'admin@foo.bar' })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
it('fails due to empty username', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: '', password: owner.password, email: owner.email })
.ok(() => true);
expect(response.statusCode).to.eql(400);
});
it('activation fails without email', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: USERNAME, password: PASSWORD })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
it('fails without email', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.username, password: owner.password })
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('fails due to empty email', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: 'someuser', password: 'ADSF#asd546', email: '' })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
it('fails due to empty email', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.username, password: owner.password, email: '' })
.ok(() => true);
expect(response.statusCode).to.eql(400);
});
it('fails due to invalid email', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: 'someuser', password: 'ADSF#asd546', email: 'invalidemail' })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
it('fails due to invalid email', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.username, password: owner.password, email: 'invalidemail' })
.ok(() => true);
expect(response.statusCode).to.eql(400);
});
it('activation fails without password', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: USERNAME, email: EMAIL })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
it('fails without password', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.password.username, email: owner.email })
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('fails due to empty password', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: 'someuser', password: '', email: 'admin@foo.bar' })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
it('fails due to empty password', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.username, password: '', email: owner.email })
.ok(() => true);
expect(response.statusCode).to.eql(400);
});
it('activation fails with invalid password', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: USERNAME, password: 'short', email: EMAIL })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(400);
it('fails with invalid password', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.username, password: 'short', email: owner.email })
.ok(() => true);
done();
});
expect(response.statusCode).to.eql(400);
});
it('fails due to missing setupToken', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.send({ username: '', password: 'somepassword', email: 'admin@foo.bar' })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
it('fails due to wrong displayName type', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.username, password: owner.password, email: owner.email, displayName: 1234 })
.ok(() => true);
expect(response.statusCode).to.eql(400);
});
it('fails due to wrong displayName type', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: 'someuser', password: 'ADSF?#asd546', email: 'admin@foo.bar', displayName: 1234 })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
it('succeeds', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.username, password: owner.password, email: owner.email, displayName: owner.displayName });
expect(response.statusCode).to.equal(201);
expect(response.body.token).to.be.a('string');
});
it('succeeds', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: 'someuser', password: 'ADSF#asd546', email: 'admin@foo.bar', displayName: 'tester' })
.end(function (error, result) {
expect(result.statusCode).to.equal(201);
expect(result.body.token).to.be.a('string');
done();
});
it('fails the second time', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/activate`)
.send({ username: owner.username, password: owner.password, email: owner.email, displayName: owner.displayName })
.ok(() => true);
expect(response.statusCode).to.eql(409);
});
it('fails the second time', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: 'someuser', password: 'ADSF#asd546', email: 'admin@foo.bar' })
.end(function (error, result) {
expect(result.statusCode).to.equal(409);
done();
});
it('after fails', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/cloudron/setup`)
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, adminFqdn: 'my.' + DOMAIN, config: {}, tlsConfig: { provider: 'fallback' } } })
.ok(() => true);
expect(response.statusCode).to.eql(409);
});
it('dns setup after activation fails', function (done) {
superagent.post(SERVER_URL + '/api/v1/cloudron/setup')
.send({ dnsConfig: { provider: 'noop', domain: DOMAIN, DOMAIN, config: {} } })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(409);
done();
});
});
it('device left first time mode', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/status')
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.activated).to.be.ok();
done();
});
it('device left first time mode', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/status`);
expect(response.statusCode).to.equal(200);
expect(response.body.activated).to.be.ok();
});
});
});