From e2e70da4c52bd5b96d8624dc20618c68e354c4bf Mon Sep 17 00:00:00 2001 From: Girish Ramakrishnan Date: Thu, 2 Jun 2016 12:51:39 -0700 Subject: [PATCH] restrict length to 32 --- src/settings.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/settings.js b/src/settings.js index 695d0f546..0c1adbccd 100644 --- a/src/settings.js +++ b/src/settings.js @@ -166,7 +166,10 @@ function setCloudronName(name, callback) { assert.strictEqual(typeof name, 'string'); assert.strictEqual(typeof callback, 'function'); - if (!name) return callback(new SettingsError(SettingsError.BAD_FIELD)); + if (!name) return callback(new SettingsError(SettingsError.BAD_FIELD, 'name is empty')); + + // some arbitrary restrictions (for sake of ui layout) + if (name.length > 32) return callback(new SettingsError(SettingsError.BAD_FIELD, 'name cannot exceed 32 characters')); settingsdb.set(exports.CLOUDRON_NAME_KEY, name, function (error) { if (error) return callback(new SettingsError(SettingsError.INTERNAL_ERROR, error));