jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

remove redundant call to canBackupApp

Browse Source
This commit is contained in:
Girish Ramakrishnan
2020-05-27 22:48:48 -07:00
parent 32a4450e5e
commit e1a718c78f
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backups.js
+2 -4
View File
@@ -1109,8 +1109,6 @@ function uploadAppSnapshot(backupConfig, app, progressCallback, callback) {
assert.strictEqual(typeof progressCallback, 'function'); assert.strictEqual(typeof progressCallback, 'function');
assert.strictEqual(typeof callback, 'function'); assert.strictEqual(typeof callback, 'function');
if (!canBackupApp(app)) return callback(); // nothing to do
var startTime = new Date(); var startTime = new Date();
snapshotApp(app, progressCallback, function (error) { snapshotApp(app, progressCallback, function (error) {
@@ -1146,7 +1144,7 @@ function backupAppWithTag(app, tag, options, progressCallback, callback) {
assert.strictEqual(typeof progressCallback, 'function'); assert.strictEqual(typeof progressCallback, 'function');
assert.strictEqual(typeof callback, 'function'); assert.strictEqual(typeof callback, 'function');
if (!canBackupApp(app)) return callback(); // nothing to do if (!canBackupApp(app)) return callback(null, null); // nothing to do
settings.getBackupConfig(function (error, backupConfig) { settings.getBackupConfig(function (error, backupConfig) {
if (error) return callback(error); if (error) return callback(error);
@@ -1195,7 +1193,7 @@ function backupBoxAndApps(progressCallback, callback) {
} }
backupAppWithTag(app, tag, { /* options */ }, (progress) => progressCallback({ percent: percent, message: progress.message }), function (error, backupId) { backupAppWithTag(app, tag, { /* options */ }, (progress) => progressCallback({ percent: percent, message: progress.message }), function (error, backupId) {
if (error && error.reason !== BoxError.BAD_STATE) { if (error) {
debugApp(app, 'Unable to backup', error); debugApp(app, 'Unable to backup', error);
return iteratorCallback(error); return iteratorCallback(error);
} }