diff --git a/src/apps.js b/src/apps.js index 01f38a0b8..6e5249947 100644 --- a/src/apps.js +++ b/src/apps.js @@ -536,10 +536,9 @@ async function checkStorage(app, volumeId, prefix) { return null; } -function getDuplicateErrorDetails(errorMessage, locations, domainObjectMap, portBindings) { +function getDuplicateErrorDetails(errorMessage, locations, portBindings) { assert.strictEqual(typeof errorMessage, 'string'); assert(Array.isArray(locations)); - assert.strictEqual(typeof domainObjectMap, 'object'); assert.strictEqual(typeof portBindings, 'object'); const match = errorMessage.match(/ER_DUP_ENTRY: Duplicate entry '(.*)' for key '(.*)'/); @@ -1418,7 +1417,7 @@ async function install(data, auditSource) { }; const [addError] = await safe(add(appId, appStoreId, manifest, subdomain, domain, translatePortBindings(portBindings, manifest), app)); - if (addError && addError.reason === BoxError.ALREADY_EXISTS) throw getDuplicateErrorDetails(addError.message, locations, domainObjectMap, portBindings); + if (addError && addError.reason === BoxError.ALREADY_EXISTS) throw getDuplicateErrorDetails(addError.message, locations, portBindings); if (addError) throw addError; await purchaseApp({ appId, appstoreId: appStoreId, manifestId: manifest.id || 'customapp' }); @@ -1861,7 +1860,7 @@ async function setLocation(app, data, auditSource) { values }; let [taskError, taskId] = await safe(addTask(appId, exports.ISTATE_PENDING_LOCATION_CHANGE, task, auditSource)); - if (taskError && taskError.reason === BoxError.ALREADY_EXISTS) taskError = getDuplicateErrorDetails(taskError.message, locations, domainObjectMap, data.portBindings); + if (taskError && taskError.reason === BoxError.ALREADY_EXISTS) taskError = getDuplicateErrorDetails(taskError.message, locations, data.portBindings); if (taskError) throw taskError; values.fqdn = dns.fqdn(values.subdomain, values.domain); @@ -2324,7 +2323,7 @@ async function clone(app, data, user, auditSource) { }; const [addError] = await safe(add(newAppId, appStoreId, manifest, subdomain, domain, translatePortBindings(portBindings, manifest), obj)); - if (addError && addError.reason === BoxError.ALREADY_EXISTS) throw getDuplicateErrorDetails(addError.message, locations, domainObjectMap, portBindings); + if (addError && addError.reason === BoxError.ALREADY_EXISTS) throw getDuplicateErrorDetails(addError.message, locations, portBindings); if (addError) throw addError; await purchaseApp({ appId: newAppId, appstoreId: app.appStoreId, manifestId: manifest.id || 'customapp' });