From e13c5c8e1a555bf27f512786b266b7b40ba0b5d2 Mon Sep 17 00:00:00 2001 From: Johannes Zellner Date: Thu, 7 Oct 2021 17:17:45 +0200 Subject: [PATCH] Do not duplicate sshd_config file path --- src/routes/support.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/routes/support.js b/src/routes/support.js index 756a1dcc1..b8dd4cf40 100644 --- a/src/routes/support.js +++ b/src/routes/support.js @@ -59,9 +59,10 @@ async function canEnableRemoteSupport(req, res, next) { if (!supportConfig.remoteSupport) return next(new HttpError(405, 'feature disabled by admin')); - const sshdConfig = safe.fs.readFileSync('/etc/ssh/sshd_config', 'utf8'); - if (!sshdConfig) return next(new HttpError(412, 'Failed to read sshd config')); - if (!sshdConfig.split('\n').find(function (line) { return line.search(/^PermitRootLogin.*yes/) !== -1; })) return next(new HttpError(417, 'Set "PermitRootLogin yes" in /etc/ssh/sshd_config')); + const SSHD_CONFIG_FILE = '/etc/ssh/sshd_config'; + const sshdConfig = safe.fs.readFileSync(SSHD_CONFIG_FILE, 'utf8'); + if (!sshdConfig) return next(new HttpError(412, `Failed to read file ${SSHD_CONFIG_FILE}`)); + if (!sshdConfig.split('\n').find(function (line) { return line.search(/^PermitRootLogin.*yes/) !== -1; })) return next(new HttpError(417, `Set "PermitRootLogin yes" in ${SSHD_CONFIG_FILE}`)); next(); }