From dfa5a0f5fe4b952bb8f12457803c8a7a500f2f52 Mon Sep 17 00:00:00 2001 From: Girish Ramakrishnan Date: Sun, 5 May 2019 10:52:39 -0700 Subject: [PATCH] subscribe must return 201 --- src/routes/subscription.js | 2 +- src/routes/test/appstore-test.js | 2 +- src/routes/test/subscription-test.js | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/routes/subscription.js b/src/routes/subscription.js index aec316b03..bc27e64f3 100644 --- a/src/routes/subscription.js +++ b/src/routes/subscription.js @@ -25,7 +25,7 @@ function subscribeCloudron(req, res, next) { if (error && error.reason === AppstoreError.EXTERNAL_ERROR) return next(new HttpError(424, error.message)); if (error) return next(new HttpError(500, error)); - next(new HttpSuccess(200, {})); + next(new HttpSuccess(201, {})); }); } diff --git a/src/routes/test/appstore-test.js b/src/routes/test/appstore-test.js index 5e5821bf5..8daff4156 100644 --- a/src/routes/test/appstore-test.js +++ b/src/routes/test/appstore-test.js @@ -94,7 +94,7 @@ describe('Appstore API', function () { .send({ email: 'test@cloudron.io', password: 'secret', signup: false }) .query({ access_token: token }) .end(function (error, result) { - expect(result.statusCode).to.equal(200); + expect(result.statusCode).to.equal(201); expect(scope1.isDone()).to.be.ok(); expect(scope2.isDone()).to.be.ok(); done(); diff --git a/src/routes/test/subscription-test.js b/src/routes/test/subscription-test.js index fc4c79d31..201b6ba66 100644 --- a/src/routes/test/subscription-test.js +++ b/src/routes/test/subscription-test.js @@ -76,7 +76,7 @@ describe('Subscription API', function () { .send({ email: 'test@cloudron.io', password: 'secret', signup: false }) .query({ access_token: token }) .end(function (error, result) { - expect(result.statusCode).to.equal(200); + expect(result.statusCode).to.equal(201); expect(scope1.isDone()).to.be.ok(); expect(scope2.isDone()).to.be.ok(); done(); @@ -100,7 +100,7 @@ describe('Subscription API', function () { .send({ email: 'test@cloudron.io', password: 'secret', signup: true }) .query({ access_token: token }) .end(function (error, result) { - expect(result.statusCode).to.equal(200); + expect(result.statusCode).to.equal(201); expect(scope1.isDone()).to.be.ok(); expect(scope2.isDone()).to.be.ok(); expect(scope3.isDone()).to.be.ok();