Merge readonlyRootfs and development mode into debug mode

The core issue we want to solve is to debug a running app.
Let's make it explicit that it is in debugging mode because
functions like update/backup/restore don't work.

Part of #171
This commit is contained in:
Girish Ramakrishnan
2017-01-20 05:48:25 -08:00
parent e437671baf
commit db6474ef2a
9 changed files with 41 additions and 59 deletions

View File

@@ -56,8 +56,7 @@ function removeInternalAppFields(app) {
altDomain: app.altDomain,
xFrameOptions: app.xFrameOptions,
sso: app.sso,
readonlyRootfs: app.readonlyRootfs,
developmentMode: app.developmentMode
debugMode: app.debugMode
};
}
@@ -128,8 +127,7 @@ function installApp(req, res, next) {
if ('sso' in data && typeof data.sso !== 'boolean') return next(new HttpError(400, 'sso must be a boolean'));
if ('readonlyRootfs' in data && typeof data.readonlyRootfs !== 'boolean') return next(new HttpError(400, 'readonlyRootfs is not a boolean'));
if ('developmentMode' in data && typeof data.developmentMode !== 'boolean') return next(new HttpError(400, 'developmentMode is not a boolean'));
if (('debugMode' in data) && typeof data.debugMode !== 'object') return next(new HttpError(400, 'debugMode must be an object'));
debug('Installing app :%j', data);
@@ -167,8 +165,7 @@ function configureApp(req, res, next) {
if (data.altDomain && typeof data.altDomain !== 'string') return next(new HttpError(400, 'altDomain must be a string'));
if (data.xFrameOptions && typeof data.xFrameOptions !== 'string') return next(new HttpError(400, 'xFrameOptions must be a string'));
if ('readonlyRootfs' in data && typeof data.readonlyRootfs !== 'boolean') return next(new HttpError(400, 'readonlyRootfs is not a boolean'));
if ('developmentMode' in data && typeof data.developmentMode !== 'boolean') return next(new HttpError(400, 'developmentMode is not a boolean'));
if (('debugMode' in data) && typeof data.debugMode !== 'object') return next(new HttpError(400, 'debugMode must be an object'));
debug('Configuring app id:%s data:%j', req.params.id, data);