jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Do not use app.fqdn in href links and blindly prepend the protocol

Browse Source
This commit is contained in:
Johannes Zellner
2026-01-07 14:46:12 +01:00
parent 89baa3cabf
commit d97c608323
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dashboard/src/views/AppsView.vue
+6 -5
View File
@@ -241,7 +241,8 @@ async function refreshApps() {
// amend properties to mimick full app
for (const applink of applinks) {
applink.type = APP_TYPES.LINK;
applink.fqdn = applink.upstreamUri.replace('https://', '');
applink.origin = applink.upstreamUri;
applink.fqdn = applink.upstreamUri;
applink.manifest = { addons: {}};
applink.installationState = ISTATES.INSTALLED;
applink.runState = RSTATES.RUNNING;
@@ -339,7 +340,7 @@ onDeactivated(() => {
</div>
<TransitionGroup name="grid-animation" tag="div" class="grid" v-if="viewType === VIEW_TYPE.GRID">
<a v-for="app in filteredApps" :key="app.id" class="grid-item" :class="{ 'item-inactive': app.runState === RSTATES.STOPPED }" @click="onOpenApp(app, $event)" :href="'https://' + app.fqdn" target="_blank" :style="{ width: itemWidth }">
<a v-for="app in filteredApps" :key="app.id" class="grid-item" :class="{ 'item-inactive': app.runState === RSTATES.STOPPED }" @click="onOpenApp(app, $event)" :href="app.origin" target="_blank" :style="{ width: itemWidth }">
<img :alt="app.label || app.subdomain || app.fqdn" :src="app.iconUrl" v-fallback-image="API_ORIGIN + '/img/appicon_fallback.png'"/>
<div class="grid-item-label" v-fit-text>{{ app.label || app.subdomain || app.fqdn }}</div>
<div class="grid-item-task-label" v-if="app.type === APP_TYPES.LINK">{{ $t('app.appLink.title') }}</div>
@@ -359,12 +360,12 @@ onDeactivated(() => {
<TableView :columns="listColumns" :model="filteredApps">
<template #icon="app">
<a :href="'https://' + app.fqdn" target="_blank">
<a :href="app.origin" target="_blank">
<img :alt="app.label || app.subdomain || app.fqdn" class="list-icon" :class="{ 'item-inactive': app.runState === RSTATES.STOPPED }" :src="app.iconUrl" v-fallback-image="API_ORIGIN + '/img/appicon_fallback.png'"/>
</a>
</template>
<template #label="app">
<a :href="'https://' + app.fqdn" target="_blank">
<a :href="app.origin" target="_blank">
{{ app.label || app.subdomain || app.fqdn }}
</a>
</template>
@@ -372,7 +373,7 @@ onDeactivated(() => {
{{ app.manifest.title }}
</template>
<template #fqdn="app">
<a :href="'https://' + app.fqdn" target="_blank">
<a :href="app.origin" target="_blank">
{{ app.fqdn }}
</a>
</template>