diff --git a/src/appdb.js b/src/appdb.js index eb194f4c6..ed5d89350 100644 --- a/src/appdb.js +++ b/src/appdb.js @@ -59,7 +59,7 @@ var assert = require('assert'), var APPS_FIELDS_PREFIXED = [ 'apps.id', 'apps.appStoreId', 'apps.installationState', 'apps.installationProgress', 'apps.runState', 'apps.health', 'apps.containerId', 'apps.manifestJson', 'apps.httpPort', 'apps.location', 'apps.dnsRecordId', - 'apps.accessRestrictionJson', 'apps.lastBackupId', 'apps.lastBackupConfigJson', 'apps.oldConfigJson', 'apps.oauthProxy', 'apps.memoryLimit' ].join(','); + 'apps.accessRestrictionJson', 'apps.lastBackupId', 'apps.lastBackupConfigJson', 'apps.oldConfigJson', 'apps.memoryLimit' ].join(','); var PORT_BINDINGS_FIELDS = [ 'hostPort', 'environmentVariable', 'appId' ].join(','); @@ -92,8 +92,6 @@ function postProcess(result) { result.portBindings[environmentVariables[i]] = parseInt(hostPorts[i], 10); } - result.oauthProxy = !!result.oauthProxy; - assert(result.accessRestrictionJson === null || typeof result.accessRestrictionJson === 'string'); result.accessRestriction = safe.JSON.parse(result.accessRestrictionJson); if (result.accessRestriction && !result.accessRestriction.users) result.accessRestriction.users = []; @@ -179,7 +177,7 @@ function getAll(callback) { }); } -function add(id, appStoreId, manifest, location, portBindings, accessRestriction, oauthProxy, memoryLimit, callback) { +function add(id, appStoreId, manifest, location, portBindings, accessRestriction, memoryLimit, callback) { assert.strictEqual(typeof id, 'string'); assert.strictEqual(typeof appStoreId, 'string'); assert(manifest && typeof manifest === 'object'); @@ -187,7 +185,6 @@ function add(id, appStoreId, manifest, location, portBindings, accessRestriction assert.strictEqual(typeof location, 'string'); assert.strictEqual(typeof portBindings, 'object'); assert.strictEqual(typeof accessRestriction, 'object'); - assert.strictEqual(typeof oauthProxy, 'boolean'); assert.strictEqual(typeof memoryLimit, 'number'); assert.strictEqual(typeof callback, 'function'); @@ -198,8 +195,8 @@ function add(id, appStoreId, manifest, location, portBindings, accessRestriction var queries = [ ]; queries.push({ - query: 'INSERT INTO apps (id, appStoreId, manifestJson, installationState, location, accessRestrictionJson, oauthProxy, memoryLimit) VALUES (?, ?, ?, ?, ?, ?, ?, ?)', - args: [ id, appStoreId, manifestJson, exports.ISTATE_PENDING_INSTALL, location, accessRestrictionJson, oauthProxy, memoryLimit ] + query: 'INSERT INTO apps (id, appStoreId, manifestJson, installationState, location, accessRestrictionJson, memoryLimit) VALUES (?, ?, ?, ?, ?, ?, ?)', + args: [ id, appStoreId, manifestJson, exports.ISTATE_PENDING_INSTALL, location, accessRestrictionJson, memoryLimit ] }); Object.keys(portBindings).forEach(function (env) { diff --git a/src/test/apps-test.js b/src/test/apps-test.js index 99b3550fc..650af7ee0 100644 --- a/src/test/apps-test.js +++ b/src/test/apps-test.js @@ -37,7 +37,6 @@ describe('Apps', function () { portBindings: { PORT: 5678 }, healthy: null, accessRestriction: null, - oauthProxy: false, memoryLimit: 0 }; @@ -45,7 +44,7 @@ describe('Apps', function () { async.series([ database.initialize, database._clear, - appdb.add.bind(null, APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, APP_0.portBindings, APP_0.accessRestriction, APP_0.oauthProxy, APP_0.memoryLimit) + appdb.add.bind(null, APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, APP_0.portBindings, APP_0.accessRestriction, APP_0.memoryLimit) ], done); }); diff --git a/src/test/apptask-test.js b/src/test/apptask-test.js index 2b3b10aa0..6fcb6ef02 100644 --- a/src/test/apptask-test.js +++ b/src/test/apptask-test.js @@ -60,7 +60,6 @@ var APP = { httpPort: 4567, portBindings: null, accessRestriction: null, - oauthProxy: false, dnsRecordId: 'someDnsRecordId', memoryLimit: 0 }; @@ -85,7 +84,7 @@ describe('apptask', function () { config.set('version', '0.5.0'); async.series([ database.initialize, - appdb.add.bind(null, APP.id, APP.appStoreId, APP.manifest, APP.location, APP.portBindings, APP.accessRestriction, APP.oauthProxy, APP.memoryLimit), + appdb.add.bind(null, APP.id, APP.appStoreId, APP.manifest, APP.location, APP.portBindings, APP.accessRestriction, APP.memoryLimit), settings.setDnsConfig.bind(null, { provider: 'route53', accessKeyId: 'accessKeyId', secretAccessKey: 'secretAccessKey', endpoint: 'http://localhost:5353' }), settings.setTlsConfig.bind(null, { provider: 'caas' }) ], done); diff --git a/src/test/database-test.js b/src/test/database-test.js index 6577cd279..6b11e9723 100644 --- a/src/test/database-test.js +++ b/src/test/database-test.js @@ -476,7 +476,6 @@ describe('database', function () { portBindings: { port: 5678 }, health: null, accessRestriction: null, - oauthProxy: false, lastBackupId: null, lastBackupConfig: null, oldConfig: null, @@ -496,7 +495,6 @@ describe('database', function () { portBindings: { }, health: null, accessRestriction: { users: [ 'foobar' ] }, - oauthProxy: true, lastBackupId: null, lastBackupConfig: null, oldConfig: null, @@ -517,7 +515,7 @@ describe('database', function () { }); it('add succeeds', function (done) { - appdb.add(APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, APP_0.portBindings, APP_0.accessRestriction, APP_0.oauthProxy, APP_0.memoryLimit, function (error) { + appdb.add(APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, APP_0.portBindings, APP_0.accessRestriction, APP_0.memoryLimit, function (error) { expect(error).to.be(null); done(); }); @@ -541,7 +539,7 @@ describe('database', function () { }); it('add of same app fails', function (done) { - appdb.add(APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, [ ], APP_0.accessRestriction, APP_0.oauthProxy, APP_0.memoryLimit, function (error) { + appdb.add(APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, [ ], APP_0.accessRestriction, APP_0.memoryLimit, function (error) { expect(error).to.be.a(DatabaseError); expect(error.reason).to.be(DatabaseError.ALREADY_EXISTS); done(); @@ -571,7 +569,6 @@ describe('database', function () { APP_0.location = 'some-other-location'; APP_0.manifest.version = '0.2'; APP_0.accessRestriction = ''; - APP_0.oauthProxy = true; APP_0.httpPort = 1337; APP_0.memoryLimit = 1337; @@ -580,7 +577,6 @@ describe('database', function () { location: APP_0.location, manifest: APP_0.manifest, accessRestriction: APP_0.accessRestriction, - oauthProxy: APP_0.oauthProxy, httpPort: APP_0.httpPort, memoryLimit: APP_0.memoryLimit }; @@ -615,7 +611,7 @@ describe('database', function () { }); it('add second app succeeds', function (done) { - appdb.add(APP_1.id, APP_1.appStoreId, APP_1.manifest, APP_1.location, [ ], APP_1.accessRestriction, APP_0.oauthProxy, APP_1.memoryLimit, function (error) { + appdb.add(APP_1.id, APP_1.appStoreId, APP_1.manifest, APP_1.location, [ ], APP_1.accessRestriction, APP_1.memoryLimit, function (error) { expect(error).to.be(null); done(); }); diff --git a/src/test/ldap-test.js b/src/test/ldap-test.js index 6179858d1..92ce59c07 100644 --- a/src/test/ldap-test.js +++ b/src/test/ldap-test.js @@ -48,7 +48,6 @@ var APP_0 = { portBindings: { port: 5678 }, health: null, accessRestriction: null, - oauthProxy: false, lastBackupId: null, lastBackupConfig: null, oldConfig: null, @@ -69,7 +68,7 @@ function setup(done) { database.initialize.bind(null), database._clear.bind(null), ldapServer.start.bind(null), - appdb.add.bind(null, APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, APP_0.portBindings, APP_0.accessRestriction, APP_0.oauthProxy, APP_0.memoryLimit), + appdb.add.bind(null, APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, APP_0.portBindings, APP_0.accessRestriction, APP_0.memoryLimit), appdb.update.bind(null, APP_0.id, { containerId: APP_0.containerId }), user.createOwner.bind(null, USER_0.username, USER_0.password, USER_0.email, USER_0.displayName), user.create.bind(null, USER_1.username, USER_1.password, USER_1.email, USER_0.displayName, { invitor: USER_0 }) diff --git a/src/test/updatechecker-test.js b/src/test/updatechecker-test.js index 0ddd1125b..742c2b79c 100644 --- a/src/test/updatechecker-test.js +++ b/src/test/updatechecker-test.js @@ -196,7 +196,6 @@ describe('updatechecker - checkAppUpdates', function () { portBindings: { PORT: 5678 }, healthy: null, accessRestriction: null, - oauthProxy: false, memoryLimit: 0 }; @@ -206,7 +205,7 @@ describe('updatechecker - checkAppUpdates', function () { async.series([ database.initialize, database._clear, - appdb.add.bind(null, APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, APP_0.portBindings, APP_0.accessRestriction, APP_0.oauthProxy, APP_0.memoryLimit) + appdb.add.bind(null, APP_0.id, APP_0.appStoreId, APP_0.manifest, APP_0.location, APP_0.portBindings, APP_0.accessRestriction, APP_0.memoryLimit) ], done); });