Back to mocha!

sorry i ever left you dear mocha

node:test has two major issues:
* --bail does not work and requires strange modules and incantations.
I was able to work around this with a custom module.

* the test reporter reports _after_ the suite is run. this makes debugging
really hard. the debugs that we print all happen before the test suite summary.
poor design overall.

src/routes/test/api-test.js

@@ -1,6 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-/* jslint node:true */
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/applinks-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import applinks from '../../applinks.js';
 import common from './common.js';
 import assert from 'node:assert/strict';

src/routes/test/apppasswords-test.js

@@ -1,6 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-/* jslint node:true */
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/appstore-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import appstore from '../../appstore.js';
 import common from './common.js';
 import constants from '../../constants.js';

src/routes/test/archives-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import archives from '../../archives.js';
 import backups from '../../backups.js';
 import common from './common.js';

src/routes/test/backups-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/backupsites-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import backupSites from '../../backupsites.js';
 import common from './common.js';
 import assert from 'node:assert/strict';

src/routes/test/branding-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import constants from '../../constants.js';
 import assert from 'node:assert/strict';

src/routes/test/cloudron-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import constants from '../../constants.js';
 import common from './common.js';
 import assert from 'node:assert/strict';

src/routes/test/directoryserver-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/dockerregistries-test.js

@@ -1,6 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-/* jslint node:true */
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/domains-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import child_process from 'node:child_process';
 import common from './common.js';
 import assert from 'node:assert/strict';

src/routes/test/eventlog-test.js

@@ -1,6 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-/* jslint node:true */
-
+import { describe, it, before, after } from 'mocha';
 import async from 'async';
 import common from './common.js';
 import eventlog from '../../eventlog.js';

src/routes/test/externalldap-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/groups-test.js

@@ -1,6 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-/* jslint node:true */
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/mail-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import mail from '../../mail.js';

src/routes/test/network-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/notifications-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import notifications from '../../notifications.js';

src/routes/test/oidcclients-test.js

@@ -1,6 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-/* jslint node:true */
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/profile-test.js

@@ -1,6 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-/* jslint node:true */
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import fs from 'node:fs';

src/routes/test/provision-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import appstore from '../../appstore.js';
 import assert from 'node:assert/strict';

src/routes/test/system-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import constants from '../../constants.js';
 import common from './common.js';
 import { EventSource } from 'eventsource';

src/routes/test/tasks-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import safe from 'safetydance';

src/routes/test/tokens-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/updater-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import constants from '../../constants.js';
 import assert from 'node:assert/strict';

src/routes/test/user-directory-test.js

@@ -1,6 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-/* jslint node:true */
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import superagent from '@cloudron/superagent';

src/routes/test/users-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import fs from 'node:fs';

src/routes/test/volumes-test.js

@@ -1,5 +1,4 @@
-import { describe, it, before, after } from 'node:test';
-
+import { describe, it, before, after } from 'mocha';
 import common from './common.js';
 import assert from 'node:assert/strict';
 import safe from 'safetydance';