From d03fb0e71f42ac4f09b33ac4641d6b3fb9beceb3 Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Thu, 26 Sep 2019 13:06:15 -0700
Subject: [PATCH] Add separate flags for skipping backup and notification

---
 src/apps.js        | 4 ++--
 src/routes/apps.js | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/apps.js b/src/apps.js
index ccdc40189..892d1542b 100644
--- a/src/apps.js
+++ b/src/apps.js
@@ -1258,8 +1258,8 @@ function update(appId, data, auditSource, callback) {
             if (error) return callback(error);
 
             var updateConfig = {
-                skipNotification: data.force,
-                skipBackup: data.force
+                skipNotification: !!data.skipNotification,
+                skipBackup: !!data.skipBackup
             };
 
             error = manifestFormat.parse(manifest);
diff --git a/src/routes/apps.js b/src/routes/apps.js
index 4c7afff29..a6bbcb3c5 100644
--- a/src/routes/apps.js
+++ b/src/routes/apps.js
@@ -489,6 +489,8 @@ function updateApp(req, res, next) {
     if ('appStoreId' in data && typeof data.appStoreId !== 'string') return next(new HttpError(400, 'appStoreId must be a string'));
     if (!data.manifest && !data.appStoreId) return next(new HttpError(400, 'appStoreId or manifest is required'));
 
+    if ('skipBackup' in data && typeof data.skipBackup !== 'boolean') return next(new HttpError(400, 'skipBackup must be a boolean'));
+    if ('skipNotification' in data && typeof data.skipNotification !== 'boolean') return next(new HttpError(400, 'skipNotification must be a boolean'));
     if ('force' in data && typeof data.force !== 'boolean') return next(new HttpError(400, 'force must be a boolean'));
 
     debug('Update app id:%s to manifest:%j', req.params.id, data.manifest);