jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

minio: fix issue with accepting selfsigned certs

Browse Source
This commit is contained in:
Girish Ramakrishnan
2025-11-12 14:14:25 +01:00
parent 8d06defbcb
commit ce15958a9a
2 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/storage/s3.js
View File

@@ -96,9 +96,14 @@ function createS3Client(apiConfig, options) {
secretAccessKey: apiConfig.secretAccessKey
};
const isHttps = apiConfig.endpoint?.startsWith('https://') || apiConfig._provider === 's3';
const needsSelfSignedAgent = isHttps && (apiConfig.acceptSelfSignedCerts || apiConfig.bucket.includes('.'));
const requestHandler = new NodeHttpHandler({
connectionTimeout: 60000,
socketTimeout: 20 * 60 * 1000
socketTimeout: 20 * 60 * 1000,
...(needsSelfSignedAgent && { httpsAgent: new https.Agent({ rejectUnauthorized: false }) }),
...(!isHttps && { httpAgent: new http.Agent({}) }) // http agent is required for http endpoints
});
// sdk v3 only has signature support v4
@@ -107,22 +112,11 @@ function createS3Client(apiConfig, options) {
region: apiConfig.region || 'us-east-1',
credentials,
requestHandler,
...(options.retryStrategy && { retryStrategy: options.retryStrategy }),
...(apiConfig.endpoint && { endpoint: apiConfig.endpoint }),
// logger: console
};
if (options.retryStrategy) clientConfig.retryStrategy = options.retryStrategy;
if (apiConfig.endpoint) clientConfig.endpoint = apiConfig.endpoint;
// s3 endpoint names come from the SDK
const isHttps = clientConfig.endpoint?.startsWith('https://') || apiConfig._provider === 's3';
if (isHttps) {
if (apiConfig.acceptSelfSignedCerts || apiConfig.bucket.includes('.')) {
requestHandler.agent = new https.Agent({ rejectUnauthorized: false });
}
} else { // http agent is required for http endpoints
requestHandler.agent = new http.Agent({});
}
const client = constants.TEST ? new globalThis.S3Mock(clientConfig) : new S3(clientConfig);
// https://github.com/aws/aws-sdk-js-v3/issues/6761#issuecomment-2574480834
// client.middlewareStack.add((next, context) => async (args) => {