jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix upstreamUri validation

Browse Source
This commit is contained in:
Girish Ramakrishnan
2022-06-10 11:23:58 -07:00
parent 9bd9b72e5d
commit ce06b2e150
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/apps.js
View File

@@ -458,8 +458,9 @@ function validateBackupFormat(format) {
}
function validateUpstreamUri(upstreamUri) {
if (upstreamUri === null) return null;
assert.strictEqual(typeof upstreamUri, 'string');
if (!upstreamUri) return null;
if (upstreamUri.length > 256) return new BoxError(BoxError.BAD_FIELD, 'upstreamUri must be less than 256');
return null;
@@ -1295,7 +1296,7 @@ async function install(data, auditSource) {
overwriteDns = 'overwriteDns' in data ? data.overwriteDns : false,
skipDnsSetup = 'skipDnsSetup' in data ? data.skipDnsSetup : false,
appStoreId = data.appStoreId,
upstreamUri = data.upstreamUri,
upstreamUri = data.upstreamUri || '',
manifest = data.manifest;
let error = manifestFormat.parse(manifest);
@@ -1453,7 +1454,7 @@ async function setUpstreamUri(app, upstreamUri, auditSource) {
assert.strictEqual(typeof auditSource, 'object');
const appId = app.id;
let error = validateUpstreamUri(upstreamUri);
const error = validateUpstreamUri(upstreamUri);
if (error) throw error;
await reverseProxy.writeAppConfig(_.extend({}, app, { upstreamUri }));