From badf58db3eda7a64ba1bf509bebb87e6ed5f149e Mon Sep 17 00:00:00 2001 From: Johannes Zellner Date: Mon, 22 Apr 2019 14:41:44 +0200 Subject: [PATCH] Allow empty mail relay username and/or password --- src/mail.js | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/mail.js b/src/mail.js index bd353a202..0d2755958 100644 --- a/src/mail.js +++ b/src/mail.js @@ -165,16 +165,22 @@ function checkSmtpRelay(relay, callback) { status: false }; - var transporter = nodemailer.createTransport(smtpTransport({ + var options = { connectionTimeout: 5000, greetingTimeout: 5000, host: relay.host, - port: relay.port, - auth: { + port: relay.port + }; + + // only set auth if either username or password is provided, some relays auth based on IP (range) + if (relay.username || relay.password) { + options.auth = { user: relay.username, pass: relay.password - } - })); + }; + } + + var transporter = nodemailer.createTransport(smtpTransport(options)); transporter.verify(function(error) { result.status = !error;