diff --git a/src/appdb.js b/src/appdb.js index 37b451d2f..aca49f78c 100644 --- a/src/appdb.js +++ b/src/appdb.js @@ -221,7 +221,7 @@ function add(id, appStoreId, manifest, location, domain, portBindings, data, cal if (data.mailboxName) { queries.push({ query: 'INSERT INTO mailboxes (name, domain, ownerId, ownerType) VALUES (?, ?, ?, ?)', - args: [ data.mailboxName, domain, id, mailboxdb.TYPE_APP ] + args: [ data.mailboxName, domain, id, mailboxdb.OWNER_TYPE_APP ] }); } diff --git a/src/ldap.js b/src/ldap.js index 906e95aae..509bbddc8 100644 --- a/src/ldap.js +++ b/src/ldap.js @@ -434,7 +434,7 @@ function authenticateMailbox(req, res, next) { if (error && error.reason === MailError.NOT_FOUND) return next(new ldap.NoSuchObjectError(req.dn.toString())); if (error) return next(new ldap.OperationsError(error.message)); - if (mailbox.ownerType === mailboxdb.TYPE_APP) { + if (mailbox.ownerType === mailboxdb.OWNER_TYPE_APP) { var addonId = req.dn.rdns[1].attrs.ou.value.toLowerCase(); // 'sendmail' or 'recvmail' var name; if (addonId === 'sendmail') name = 'MAIL_SMTP_PASSWORD'; @@ -448,7 +448,7 @@ function authenticateMailbox(req, res, next) { eventlog.add(eventlog.ACTION_APP_LOGIN, { authType: 'ldap', mailboxId: name }, { appId: mailbox.ownerId, addonId: addonId }); return res.end(); }); - } else if (mailbox.ownerType === mailboxdb.TYPE_USER) { + } else if (mailbox.ownerType === mailboxdb.OWNER_TYPE_USER) { if (!domain.enabled) return next(new ldap.NoSuchObjectError(req.dn.toString())); user.verifyWithUsername(parts[0], req.credentials || '', function (error, result) { diff --git a/src/mail.js b/src/mail.js index 9628b5394..9b71128af 100644 --- a/src/mail.js +++ b/src/mail.js @@ -907,7 +907,7 @@ function addMailbox(name, domain, userId, callback) { var error = validateName(name); if (error) return callback(error); - mailboxdb.addMailbox(name, domain, userId, mailboxdb.TYPE_USER, function (error) { + mailboxdb.addMailbox(name, domain, userId, mailboxdb.OWNER_TYPE_USER, function (error) { if (error && error.reason === DatabaseError.ALREADY_EXISTS) return callback(new MailError(MailError.ALREADY_EXISTS, `mailbox ${name} already exists`)); if (error) return callback(new MailError(MailError.INTERNAL_ERROR, error)); @@ -926,7 +926,7 @@ function updateMailbox(name, domain, userId, callback) { var error = validateName(name); if (error) return callback(error); - mailboxdb.updateMailbox(name, domain, userId, mailboxdb.TYPE_USER, function (error) { + mailboxdb.updateMailbox(name, domain, userId, mailboxdb.OWNER_TYPE_USER, function (error) { if (error && error.reason === DatabaseError.NOT_FOUND) return callback(new MailError(MailError.NOT_FOUND, 'no such mailbox')); if (error) return callback(new MailError(MailError.INTERNAL_ERROR, error)); diff --git a/src/mailboxdb.js b/src/mailboxdb.js index e1fda75cf..d0eba4132 100644 --- a/src/mailboxdb.js +++ b/src/mailboxdb.js @@ -27,9 +27,9 @@ exports = module.exports = { _clear: clear, - TYPE_USER: 'user', - TYPE_APP: 'app', - TYPE_GROUP: 'group' + OWNER_TYPE_USER: 'user', + OWNER_TYPE_APP: 'app', + OWNER_TYPE_GROUP: 'group' }; var assert = require('assert'), @@ -84,7 +84,7 @@ function addGroup(name, domain, members, callback) { assert.strictEqual(typeof callback, 'function'); database.query('INSERT INTO mailboxes (name, domain, ownerId, ownerType, membersJson) VALUES (?, ?, ?, ?, ?)', - [ name, domain, 'admin', exports.TYPE_GROUP, JSON.stringify(members) ], function (error) { + [ name, domain, 'admin', exports.OWNER_TYPE_GROUP, JSON.stringify(members) ], function (error) { if (error && error.code === 'ER_DUP_ENTRY') return callback(new DatabaseError(DatabaseError.ALREADY_EXISTS, 'mailbox already exists')); if (error) return callback(new DatabaseError(DatabaseError.INTERNAL_ERROR, error)); @@ -178,7 +178,7 @@ function getMailbox(name, domain, callback) { assert.strictEqual(typeof domain, 'string'); assert.strictEqual(typeof callback, 'function'); - database.query('SELECT ' + MAILBOX_FIELDS + ' FROM mailboxes WHERE name = ? AND domain = ? AND (ownerType = ? OR ownerType = ?) AND aliasTarget IS NULL', [ name, domain, exports.TYPE_APP, exports.TYPE_USER ], function (error, results) { + database.query('SELECT ' + MAILBOX_FIELDS + ' FROM mailboxes WHERE name = ? AND domain = ? AND (ownerType = ? OR ownerType = ?) AND aliasTarget IS NULL', [ name, domain, exports.OWNER_TYPE_APP, exports.OWNER_TYPE_USER ], function (error, results) { if (error) return callback(new DatabaseError(DatabaseError.INTERNAL_ERROR, error)); if (results.length === 0) return callback(new DatabaseError(DatabaseError.NOT_FOUND)); @@ -190,7 +190,7 @@ function listMailboxes(domain, callback) { assert.strictEqual(typeof domain, 'string'); assert.strictEqual(typeof callback, 'function'); - database.query('SELECT ' + MAILBOX_FIELDS + ' FROM mailboxes WHERE domain = ? AND (ownerType = ? OR ownerType = ?) AND aliasTarget IS NULL ORDER BY name', [ domain, exports.TYPE_APP, exports.TYPE_USER ], function (error, results) { + database.query('SELECT ' + MAILBOX_FIELDS + ' FROM mailboxes WHERE domain = ? AND (ownerType = ? OR ownerType = ?) AND aliasTarget IS NULL ORDER BY name', [ domain, exports.OWNER_TYPE_APP, exports.OWNER_TYPE_USER ], function (error, results) { if (error) return callback(new DatabaseError(DatabaseError.INTERNAL_ERROR, error)); results.forEach(function (result) { postProcess(result); }); @@ -203,7 +203,7 @@ function listGroups(domain, callback) { assert.strictEqual(typeof domain, 'string'); assert.strictEqual(typeof callback, 'function'); - database.query('SELECT ' + MAILBOX_FIELDS + ' FROM mailboxes WHERE domain = ? AND ownerType = ? AND aliasTarget IS NULL',[ domain, exports.TYPE_GROUP ], function (error, results) { + database.query('SELECT ' + MAILBOX_FIELDS + ' FROM mailboxes WHERE domain = ? AND ownerType = ? AND aliasTarget IS NULL',[ domain, exports.OWNER_TYPE_GROUP ], function (error, results) { if (error) return callback(new DatabaseError(DatabaseError.INTERNAL_ERROR, error)); results.forEach(function (result) { postProcess(result); }); @@ -217,7 +217,7 @@ function getGroup(name, domain, callback) { assert.strictEqual(typeof domain, 'string'); assert.strictEqual(typeof callback, 'function'); - database.query('SELECT ' + MAILBOX_FIELDS + ' FROM mailboxes WHERE name = ? AND domain = ? AND ownerType = ? AND aliasTarget IS NULL', [ name, domain, exports.TYPE_GROUP ], function (error, results) { + database.query('SELECT ' + MAILBOX_FIELDS + ' FROM mailboxes WHERE name = ? AND domain = ? AND ownerType = ? AND aliasTarget IS NULL', [ name, domain, exports.OWNER_TYPE_GROUP ], function (error, results) { if (error) return callback(new DatabaseError(DatabaseError.INTERNAL_ERROR, error)); if (results.length === 0) return callback(new DatabaseError(DatabaseError.NOT_FOUND)); diff --git a/src/test/database-test.js b/src/test/database-test.js index 21f6d3db7..67f3387ff 100644 --- a/src/test/database-test.js +++ b/src/test/database-test.js @@ -1596,21 +1596,21 @@ describe('database', function () { }); it('add user mailbox succeeds', function (done) { - mailboxdb.addMailbox('girish', DOMAIN_0.domain, 'uid-0', mailboxdb.TYPE_USER, function (error) { + mailboxdb.addMailbox('girish', DOMAIN_0.domain, 'uid-0', mailboxdb.OWNER_TYPE_USER, function (error) { expect(error).to.be(null); done(); }); }); it('cannot add dup entry', function (done) { - mailboxdb.addMailbox('girish', DOMAIN_0.domain, 'uid-1', mailboxdb.TYPE_APP, function (error) { + mailboxdb.addMailbox('girish', DOMAIN_0.domain, 'uid-1', mailboxdb.OWNER_TYPE_APP, function (error) { expect(error.reason).to.be(DatabaseError.ALREADY_EXISTS); done(); }); }); it('add app mailbox succeeds', function (done) { - mailboxdb.addMailbox('support', DOMAIN_0.domain, 'osticket', mailboxdb.TYPE_APP, function (error) { + mailboxdb.addMailbox('support', DOMAIN_0.domain, 'osticket', mailboxdb.OWNER_TYPE_APP, function (error) { expect(error).to.be(null); done(); }); @@ -1633,7 +1633,7 @@ describe('database', function () { expect(error).to.be(null); expect(mailboxes.length).to.be(2); expect(mailboxes[0].name).to.be('girish'); - expect(mailboxes[0].ownerType).to.be(mailboxdb.TYPE_USER); + expect(mailboxes[0].ownerType).to.be(mailboxdb.OWNER_TYPE_USER); expect(mailboxes[1].name).to.be('support'); done(); diff --git a/src/test/ldap-test.js b/src/test/ldap-test.js index f94b53db5..7650af2e1 100644 --- a/src/test/ldap-test.js +++ b/src/test/ldap-test.js @@ -103,7 +103,7 @@ function setup(done) { appdb.update.bind(null, APP_0.id, { containerId: APP_0.containerId }), appdb.setAddonConfig.bind(null, APP_0.id, 'sendmail', [{ name: 'MAIL_SMTP_PASSWORD', value : 'sendmailpassword' }]), appdb.setAddonConfig.bind(null, APP_0.id, 'recvmail', [{ name: 'MAIL_IMAP_PASSWORD', value : 'recvmailpassword' }]), - mailboxdb.addMailbox.bind(null, APP_0.location + '.app', APP_0.domain, APP_0.id, mailboxdb.TYPE_APP), + mailboxdb.addMailbox.bind(null, APP_0.location + '.app', APP_0.domain, APP_0.id, mailboxdb.OWNER_TYPE_APP), function (callback) { user.createOwner(USER_0.username, USER_0.password, USER_0.email, USER_0.displayName, AUDIT_SOURCE, function (error, result) { @@ -739,7 +739,7 @@ describe('Ldap', function () { describe('search mailbox', function () { before(function (done) { - mailboxdb.addMailbox(USER_0.username.toLowerCase(), DOMAIN_0.domain, USER_0.id, mailboxdb.TYPE_USER, done); + mailboxdb.addMailbox(USER_0.username.toLowerCase(), DOMAIN_0.domain, USER_0.id, mailboxdb.OWNER_TYPE_USER, done); }); it('get specific mailbox by email', function (done) {