Fix various linter errors

src/routes/test/appstore-test.js

@@ -5,7 +5,6 @@ import common from './common.js';
 import constants from '../../constants.js';
 import expect from 'expect.js';
 import nock from 'nock';
-import settings from '../../settings.js';
 import superagent from '@cloudron/superagent';
 
 /* global describe:false */

src/routes/test/cloudron-test.js

@@ -143,7 +143,6 @@ describe('Cloudron', function () {
             const email = 'setup3@account.com';
             const password = 'test?!3434543534';
             const username = 'setupuser3';
-            const displayName = 'setup user3';
 
             const response0 = await superagent.post(`${serverUrl}/api/v1/user_directory/profile_config`)
                 .query({ access_token: owner.token })

src/routes/test/dockerregistries-test.js

@@ -1,7 +1,6 @@
 /* jslint node:true */
 
 import common from './common.js';
-import constants from '../../constants.js';
 import expect from 'expect.js';
 import superagent from '@cloudron/superagent';
 

src/routes/test/users-test.js

@@ -383,13 +383,11 @@ describe('Users API', function () {
         });
 
         it('can change avatar', async function () {
-            let customAvatarSize = 0;
-
             const response = await superagent.post(`${serverUrl}/api/v1/users/${user2.id}/avatar`)
                 .query({ access_token: owner.token })
                 .attach('avatar', './logo.png');
 
-            customAvatarSize = fs.readFileSync('./logo.png').length;
+            const customAvatarSize = fs.readFileSync('./logo.png').length;
 
             expect(response.status).to.equal(204);
 

src/routes/test/volumes-test.js

@@ -68,7 +68,7 @@ describe('Volumes API', function () {
     });
 
     it('cannot update volume', async function () {
-        const [error, response] = await safe(superagent.post(`${serverUrl}/api/v1/volumes/${volumeId}`)
+        const [, response] = await safe(superagent.post(`${serverUrl}/api/v1/volumes/${volumeId}`)
             .query({ access_token: owner.token })
             .send({ mountOptions: { hostPath: '/media/cloudron-test-music-2' }})
             .ok(() => true));