From b34d09f547ca0a6e77bc6995268f37ae1204c6f3 Mon Sep 17 00:00:00 2001 From: Girish Ramakrishnan Date: Wed, 8 Feb 2017 10:13:50 -0800 Subject: [PATCH] ldap: Fix crash if displayName is empty and username is null --- src/ldap.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ldap.js b/src/ldap.js index 954127e2c..c2d31e269 100644 --- a/src/ldap.js +++ b/src/ldap.js @@ -51,7 +51,7 @@ function userSearch(req, res, next) { var groups = [ GROUP_USERS_DN ]; if (entry.admin) groups.push(GROUP_ADMINS_DN); - var displayName = entry.displayName || entry.username; + var displayName = entry.displayName || entry.username || ''; // displayName can be empty and username can be null var nameParts = displayName.split(' '); var firstName = nameParts[0]; var lastName = nameParts.length > 1 ? nameParts[nameParts.length - 1] : ''; // choose last part, if it exists