jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

rename some variables for clarity

Browse Source
This commit is contained in:
Girish Ramakrishnan
2025-11-23 15:35:18 +01:00
parent 4c5d67606f
commit ae2f74777b
2 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dashboard/src/components/GroupDialog.vue
+9 -8
View File
@@ -19,9 +19,9 @@ const group = ref(null);
const busy = ref(false);
const formError = ref({});
const name = ref('');
const users = ref([]);
const userIds = ref([]);
const allUsers = ref([]);
const apps = ref([]);
const appIds = ref([]);
const allApps = ref([]);
async function onSubmit() {
@@ -29,7 +29,7 @@ async function onSubmit() {
formError.value = {};
if (group.value) {
const [error] = await groupsModel.update(group.value.id, name.value, users.value, apps.value);
const [error] = await groupsModel.update(group.value.id, name.value, userIds.value, appIds.value);
if (error) {
if (error.body && error.body.message.indexOf('name') === 0) formError.value.name = error.body.message;
else formError.value.generic = error.body ? error.body.message : 'Internal error';
@@ -37,7 +37,7 @@ async function onSubmit() {
return console.error(error);
}
} else {
const [error] = await groupsModel.add(name.value, users.value, apps.value);
const [error] = await groupsModel.add(name.value, userIds.value, appIds.value);
if (error) {
if (error.body && error.body.message.indexOf('name') === 0) formError.value.name = error.body.message;
else formError.value.generic = error.body ? error.body.message : 'Internal error';
@@ -63,13 +63,13 @@ defineExpose({
if (error) return console.error(error);
result.forEach(u => u.label = (u.username || u.email));
allUsers.value = result;
users.value = g ? g.userIds : [];
userIds.value = g ? g.userIds : [];
[error, result] = await appsModel.list();
if (error) return console.error(error);
result.forEach(a => a.label = (a.label || a.fqdn));
allApps.value = result;
apps.value = g ? g.appIds : [];
appIds.value = g ? g.appIds : [];
dialog.value.open();
}
@@ -103,13 +103,14 @@ defineExpose({
<FormGroup>
<label for="usersInput">{{ $t('users.group.users') }}</label>
<!-- membership of external groups cannot be edited -->
<div v-if="group?.source"><span v-for="user of groupEdit.selectedUsers" :key="user.id"> {{ (user.username || user.email) }}</span></div>
<MultiSelect v-else v-model="users" :options="allUsers" option-key="id" :search-threshold="20"/>
<MultiSelect v-else v-model="userIds" :options="allUsers" option-key="id" :search-threshold="20"/>
</FormGroup>
<FormGroup>
<label for="appsInput">{{ $t('users.group.allowedApps') }}</label>
<MultiSelect v-model="apps" :options="allApps" option-key="id" :search-threshold="20"/>
<MultiSelect v-model="appIds" :options="allApps" option-key="id" :search-threshold="20"/>
</FormGroup>
</fieldset>
</form>