tests: more common'ification

This commit is contained in:
Girish Ramakrishnan
2021-08-12 16:27:31 -07:00
parent 05576b5a91
commit ac5b7f8093
6 changed files with 588 additions and 896 deletions

View File

@@ -5,256 +5,182 @@
'use strict';
var async = require('async'),
constants = require('../../constants.js'),
database = require('../../database.js'),
const common = require('./common.js'),
expect = require('expect.js'),
fs = require('fs'),
nock = require('nock'),
path = require('path'),
paths = require('../../paths.js'),
safe = require('safetydance'),
settings = require('../../settings.js'),
settingsdb = require('../../settingsdb.js'),
superagent = require('superagent'),
server = require('../../server.js');
var SERVER_URL = 'http://localhost:' + constants.PORT;
var USERNAME = 'superadmin', PASSWORD = 'Foobar?1337', EMAIL ='silly@me.com';
var AUTHORIZED_KEYS_FILE = path.join(paths.baseDir(), 'authorized_keys');
var token = null;
function setup(done) {
nock.cleanAll();
safe.fs.unlinkSync(AUTHORIZED_KEYS_FILE);
async.series([
server.start.bind(server),
database._clear,
function createAdmin(callback) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: USERNAME, password: PASSWORD, email: EMAIL })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(201);
// stash token for further use
token = result.body.token;
callback();
});
},
settingsdb.set.bind(null, settings.CLOUDRON_TOKEN_KEY, 'CLOUDRON_TOKEN')
], done);
}
function cleanup(done) {
database._clear(function (error) {
expect(error).to.not.be.ok();
server.stop(done);
});
}
support = require('../../support.js'),
superagent = require('superagent');
describe('Support API', function () {
const { setup, cleanup, serverUrl, owner, mockApiServerOrigin, appstoreToken } = common;
before(setup);
after(cleanup);
const authorizedKeysFile = support._sshInfo().filePath;
describe('remote support', function () {
before(setup);
after(cleanup);
it('get remote support', function (done) {
superagent.get(SERVER_URL + '/api/v1/support/remote_support')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.enabled).to.be(false);
done();
});
it('get remote support', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/support/remote_support`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.enabled).to.be(false);
});
it('enable remote support', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/remote_support')
.query({ access_token: token })
.send({ enable: true })
.end(function (err, res) {
expect(res.statusCode).to.equal(202);
it('enable remote support', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/remote_support`)
.query({ access_token: owner.token })
.send({ enable: true });
let data = safe.fs.readFileSync(AUTHORIZED_KEYS_FILE, 'utf8');
let count = (data.match(/support@cloudron.io/g) || []).length;
expect(count).to.be(1);
done();
});
expect(response.statusCode).to.equal(202);
let data = await fs.promises.readFile(authorizedKeysFile, 'utf8');
let count = (data.match(/support@cloudron.io/g) || []).length;
expect(count).to.be(1);
});
it('returns true when remote support enabled', function (done) {
superagent.get(SERVER_URL + '/api/v1/support/remote_support')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.enabled).to.be(true);
done();
});
it('returns true when remote support enabled', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/support/remote_support`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.enabled).to.be(true);
});
it('enable remote support (again)', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/remote_support')
.query({ access_token: token })
.send({ enable: true })
.end(function (err, res) {
expect(res.statusCode).to.equal(202);
it('enable remote support (again)', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/remote_support`)
.query({ access_token: owner.token })
.send({ enable: true });
expect(response.statusCode).to.equal(202);
let data = safe.fs.readFileSync(AUTHORIZED_KEYS_FILE, 'utf8');
let count = (data.match(/support@cloudron.io/g) || []).length;
expect(count).to.be(1);
done();
});
let data = await fs.promises.readFile(authorizedKeysFile, 'utf8');
let count = (data.match(/support@cloudron.io/g) || []).length;
expect(count).to.be(1);
});
it('disable remote support', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/remote_support')
.query({ access_token: token })
.send({ enable: false })
.end(function (err, res) {
expect(res.statusCode).to.equal(202);
it('disable remote support', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/remote_support`)
.query({ access_token: owner.token })
.send({ enable: false });
let data = safe.fs.readFileSync(AUTHORIZED_KEYS_FILE, 'utf8');
let count = (data.match(/support@cloudron.io/g) || []).length;
expect(count).to.be(0);
done();
});
expect(response.statusCode).to.equal(202);
let data = await fs.promises.readFile(authorizedKeysFile, 'utf8');
let count = (data.match(/support@cloudron.io/g) || []).length;
expect(count).to.be(0);
});
it('disable remote support (again)', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/remote_support')
.query({ access_token: token })
.send({ enable: false })
.end(function (err, res) {
expect(res.statusCode).to.equal(202);
it('disable remote support (again)', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/remote_support`)
.query({ access_token: owner.token })
.send({ enable: false });
let data = safe.fs.readFileSync(AUTHORIZED_KEYS_FILE, 'utf8');
let count = (data.match(/support@cloudron.io/g) || []).length;
expect(count).to.be(0);
done();
});
expect(response.statusCode).to.equal(202);
const data = await fs.promises.readFile(authorizedKeysFile, 'utf8');
const count = (data.match(/support@cloudron.io/g) || []).length;
expect(count).to.be(0);
});
});
describe('ticket', function () {
before(setup);
after(cleanup);
it('fails without token', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/ticket')
it('fails without token', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: 'ticket', subject: 'some subject', description: 'some description' })
.end(function (error, result) {
expect(result.statusCode).to.equal(401);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(401);
});
it('fails without type', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/ticket')
it('fails without type', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ subject: 'some subject', description: 'some description' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
.query({ access_token: owner.token })
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('fails with empty type', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/ticket')
it('fails with empty type', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: '', subject: 'some subject', description: 'some description' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
.query({ access_token: owner.token })
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('fails with unknown type', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/ticket')
it('fails with unknown type', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: 'foobar', subject: 'some subject', description: 'some description' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
.query({ access_token: owner.token })
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('fails without description', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/ticket')
it('fails without description', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: 'ticket', subject: 'some subject' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
.query({ access_token: owner.token })
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('fails with empty subject', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/ticket')
it('fails with empty subject', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: 'ticket', subject: '', description: 'some description' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
.query({ access_token: owner.token })
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('fails with empty description', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/ticket')
it('fails with empty description', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: 'ticket', subject: 'some subject', description: '' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
.query({ access_token: owner.token })
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('fails without subject', function (done) {
superagent.post(SERVER_URL + '/api/v1/support/ticket')
it('fails without subject', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: 'ticket', description: 'some description' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(400);
done();
});
.query({ access_token: owner.token })
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('succeeds with ticket type', function (done) {
var scope2 = nock(settings.apiServerOrigin())
it('succeeds with ticket type', async function () {
const scope2 = nock(mockApiServerOrigin)
.filteringRequestBody(function (/* unusedBody */) { return ''; }) // strip out body
.post('/api/v1/ticket?accessToken=CLOUDRON_TOKEN')
.post(`/api/v1/ticket?accessToken=${appstoreToken}`)
.reply(201, { });
superagent.post(SERVER_URL + '/api/v1/support/ticket')
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: 'ticket', subject: 'some subject', description: 'some description' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(201);
expect(scope2.isDone()).to.be.ok();
done();
});
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(201);
expect(scope2.isDone()).to.be.ok();
});
it('succeeds with app type', function (done) {
var scope2 = nock(settings.apiServerOrigin())
it('succeeds with app type', async function () {
const scope2 = nock(mockApiServerOrigin)
.filteringRequestBody(function (/* unusedBody */) { return ''; }) // strip out body
.post('/api/v1/ticket?accessToken=CLOUDRON_TOKEN')
.post(`/api/v1/ticket?accessToken=${appstoreToken}`)
.reply(201, { });
superagent.post(SERVER_URL + '/api/v1/support/ticket')
const response = await superagent.post(`${serverUrl}/api/v1/support/ticket`)
.send({ type: 'app_missing', subject: 'some subject', description: 'some description' })
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(201);
expect(scope2.isDone()).to.be.ok();
done();
});
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(201);
expect(scope2.isDone()).to.be.ok();
});
});
});