tests: more common'ification

This commit is contained in:
Girish Ramakrishnan
2021-08-12 16:27:31 -07:00
parent 05576b5a91
commit ac5b7f8093
6 changed files with 588 additions and 896 deletions
+199 -290
View File
@@ -5,139 +5,77 @@
/* global before:false */
/* global after:false */
var async = require('async'),
const common = require('./common.js'),
constants = require('../../constants.js'),
database = require('../../database.js'),
expect = require('expect.js'),
fs = require('fs'),
rimraf = require('rimraf'),
server = require('../../server.js'),
superagent = require('superagent');
var SERVER_URL = 'http://localhost:' + constants.PORT;
var USERNAME = 'superadmin', PASSWORD = 'Foobar?1337', EMAIL ='silly@me.com';
var BACKUP_FOLDER = '/tmp/backup_test';
var token = null;
function setup(done) {
fs.mkdirSync(BACKUP_FOLDER, { recursive: true });
async.series([
server.start.bind(null),
database._clear.bind(null),
function createAdmin(callback) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: USERNAME, password: PASSWORD, email: EMAIL })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(201);
// stash token for further use
token = result.body.token;
callback();
});
}
], done);
}
function cleanup(done) {
rimraf.sync(BACKUP_FOLDER);
database._clear(function (error) {
expect(!error).to.be.ok();
server.stop(done);
});
}
const BACKUP_FOLDER = '/tmp/backup_test';
describe('Settings API', function () {
const { setup, cleanup, serverUrl, owner } = common;
before(setup);
after(cleanup);
describe('autoupdate_pattern', function () {
it('can get app auto update pattern (default)', function (done) {
superagent.get(SERVER_URL + '/api/v1/settings/autoupdate_pattern')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.pattern).to.be.ok();
done();
});
it('can get app auto update pattern (default)', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/settings/autoupdate_pattern`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.pattern).to.be.ok();
});
it('cannot set autoupdate_pattern without pattern', function (done) {
superagent.post(SERVER_URL + '/api/v1/settings/autoupdate_pattern')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
it('cannot set autoupdate_pattern without pattern', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/settings/autoupdate_pattern`)
.query({ access_token: owner.token })
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('can set autoupdate_pattern', function (done) {
superagent.post(SERVER_URL + '/api/v1/settings/autoupdate_pattern')
.query({ access_token: token })
.send({ pattern: '00 30 11 * * 1-5' })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
done();
});
it('can set autoupdate_pattern', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/settings/autoupdate_pattern`)
.query({ access_token: owner.token })
.send({ pattern: '00 30 11 * * 1-5' });
expect(response.statusCode).to.equal(200);
});
it('can get auto update pattern', function (done) {
superagent.get(SERVER_URL + '/api/v1/settings/autoupdate_pattern')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.pattern).to.be('00 30 11 * * 1-5');
done();
});
it('can get auto update pattern', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/settings/autoupdate_pattern`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.pattern).to.be('00 30 11 * * 1-5');
});
it('can set autoupdate_pattern to never', function (done) {
superagent.post(SERVER_URL + '/api/v1/settings/autoupdate_pattern')
.query({ access_token: token })
.send({ pattern: constants.AUTOUPDATE_PATTERN_NEVER })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
done();
});
it('can set autoupdate_pattern to never', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/settings/autoupdate_pattern`)
.query({ access_token: owner.token })
.send({ pattern: constants.AUTOUPDATE_PATTERN_NEVER });
expect(response.statusCode).to.equal(200);
});
it('can get auto update pattern', function (done) {
superagent.get(SERVER_URL + '/api/v1/settings/autoupdate_pattern')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.pattern).to.be(constants.AUTOUPDATE_PATTERN_NEVER);
done();
});
it('can get auto update pattern', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/settings/autoupdate_pattern`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.pattern).to.be(constants.AUTOUPDATE_PATTERN_NEVER);
});
it('cannot set invalid autoupdate_pattern', function (done) {
superagent.post(SERVER_URL + '/api/v1/settings/autoupdate_pattern')
.query({ access_token: token })
it('cannot set invalid autoupdate_pattern', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/settings/autoupdate_pattern`)
.query({ access_token: owner.token })
.send({ pattern: '1 3 x 5 6' })
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
});
describe('time_zone', function () {
it('succeeds', function (done) {
superagent.get(SERVER_URL + '/api/v1/settings/time_zone')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.timeZone).to.be('America/Los_Angeles');
done();
});
it('succeeds', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/settings/time_zone`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.timeZone).to.be('America/Los_Angeles');
});
});
@@ -152,286 +90,257 @@ describe('Settings API', function () {
schedulePattern: '00 00 23 * * *' // every day at 11pm
};
it('can get backup_config (default)', function (done) {
superagent.get(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body).to.eql(defaultConfig);
done();
});
it('can get backup_config (default)', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body).to.eql(defaultConfig);
});
it('cannot set backup_config without provider', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config without provider', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
delete tmp.provider;
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with invalid provider', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with invalid provider', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.provider = 'invalid provider';
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config without schedulePattern', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config without schedulePattern', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
delete tmp.schedulePattern;
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with invalid schedulePattern', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with invalid schedulePattern', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.schedulePattern = 'not a pattern';
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config without format', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config without format', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
delete tmp.format;
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with invalid format', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with invalid format', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.format = 'invalid format';
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config without retentionPolicy', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config without retentionPolicy', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
delete tmp.retentionPolicy;
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with invalid retentionPolicy', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with invalid retentionPolicy', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.retentionPolicy = 'not an object';
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with empty retentionPolicy', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with empty retentionPolicy', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.retentionPolicy = {};
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with retentionPolicy missing properties', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with retentionPolicy missing properties', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.retentionPolicy = { foo: 'bar' };
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with retentionPolicy with invalid keepWithinSecs', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with retentionPolicy with invalid keepWithinSecs', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.retentionPolicy = { keepWithinSecs: 'not a number' };
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with invalid password', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with invalid password', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.password = 1234;
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with invalid syncConcurrency', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with invalid syncConcurrency', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.syncConcurrency = 'not a number';
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with invalid syncConcurrency', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with invalid syncConcurrency', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.syncConcurrency = 0;
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set backup_config with invalid acceptSelfSignedCerts', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('cannot set backup_config with invalid acceptSelfSignedCerts', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.acceptSelfSignedCerts = 'not a boolean';
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('can set backup_config', function (done) {
var tmp = JSON.parse(JSON.stringify(defaultConfig));
it('can set backup_config', async function () {
let tmp = JSON.parse(JSON.stringify(defaultConfig));
tmp.format = 'rsync';
tmp.backupFolder = BACKUP_FOLDER;
superagent.post(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
.send(tmp)
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
done();
});
const response = await superagent.post(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token })
.send(tmp);
expect(response.statusCode).to.equal(200);
});
it('can get backup_config', function (done) {
superagent.get(SERVER_URL + '/api/v1/settings/backup_config')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.format).to.equal('rsync');
expect(res.body.backupFolder).to.equal(BACKUP_FOLDER);
done();
});
it('can get backup_config', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/settings/backup_config`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.format).to.equal('rsync');
expect(response.body.backupFolder).to.equal(BACKUP_FOLDER);
});
});
describe('language', function () {
it('can get default language', function (done) {
superagent.get(SERVER_URL + '/api/v1/settings/language')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.language).to.equal('en');
done();
});
it('can get default language', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/settings/language`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.language).to.equal('en');
});
it('cannot set language with missing language', function (done) {
superagent.post(SERVER_URL + '/api/v1/settings/language')
.query({ access_token: token })
it('cannot set language with missing language', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/settings/language`)
.query({ access_token: owner.token })
.send({ foo: 'bar' })
.end(function (err, res) {
expect(res.statusCode).to.equal(400);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(400);
});
it('cannot set language with invalid language', function (done) {
superagent.post(SERVER_URL + '/api/v1/settings/language')
.query({ access_token: token })
it('cannot set language with invalid language', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/settings/language`)
.query({ access_token: owner.token })
.send({ language: 'doesnotexist' })
.end(function (err, res) {
expect(res.statusCode).to.equal(404);
done();
});
.ok(() => true);
expect(response.statusCode).to.equal(404);
});
it('can set language', function (done) {
superagent.post(SERVER_URL + '/api/v1/settings/language')
.query({ access_token: token })
.send({ language: 'de' })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
done();
});
it('can set language', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/settings/language`)
.query({ access_token: owner.token })
.send({ language: 'de' });
expect(response.statusCode).to.equal(200);
});
it('can get language', function (done) {
superagent.get(SERVER_URL + '/api/v1/settings/language')
.query({ access_token: token })
.end(function (err, res) {
expect(res.statusCode).to.equal(200);
expect(res.body.language).to.equal('de');
done();
});
it('can get language', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/settings/language`)
.query({ access_token: owner.token });
expect(response.statusCode).to.equal(200);
expect(response.body.language).to.equal('de');
});
});
});