diff --git a/src/apps.js b/src/apps.js index a65ad0dbf..386bbfa60 100644 --- a/src/apps.js +++ b/src/apps.js @@ -185,6 +185,7 @@ const appstore = require('./appstore.js'), volumes = require('./volumes.js'), _ = require('underscore'); +// NOTE: when adding fields here, update the clone and unarchive logic as well const APPS_FIELDS_PREFIXED = [ 'apps.id', 'apps.appStoreId', 'apps.installationState', 'apps.errorJson', 'apps.runState', 'apps.health', 'apps.containerId', 'apps.manifestJson', 'apps.accessRestrictionJson', 'apps.memoryLimit', 'apps.cpuQuota', 'apps.label', 'apps.notes', 'apps.tagsJson', 'apps.taskId', 'apps.reverseProxyConfigJson', 'apps.servicesConfigJson', 'apps.operatorsJson', @@ -2422,10 +2423,11 @@ async function clone(app, data, user, auditSource) { const icons = await getIcons(app.id); - // label, icon intentionally omitted + // label, icon, checklist intentionally omitted const dolly = _.pick(app, 'memoryLimit', 'cpuQuota', 'crontab', 'reverseProxyConfig', 'env', 'servicesConfig', 'tags', 'devices', 'enableMailbox', 'mailboxDisplayName', 'mailboxName', 'mailboxDomain', 'enableInbox', 'inboxName', 'inboxDomain', 'debugMode', - 'enableTurn', 'enableRedis', 'mounts', 'enableBackup', 'enableAutomaticUpdate', 'accessRestriction', 'operators', 'sso'); + 'enableTurn', 'enableRedis', 'mounts', 'enableBackup', 'enableAutomaticUpdate', 'accessRestriction', 'operators', 'sso', + 'notes'); if (!manifest.addons?.recvmail) dolly.inboxDomain = null; // needed because we are cloning _current_ app settings with old manifest diff --git a/src/archives.js b/src/archives.js index 1d6b4eda0..af86beb82 100644 --- a/src/archives.js +++ b/src/archives.js @@ -117,7 +117,8 @@ async function unarchive(archive, data, auditSource) { const dolly = _.pick(appConfig, 'appStoreId', 'manifest', 'memoryLimit', 'cpuQuota', 'crontab', 'reverseProxyConfig', 'env', 'servicesConfig', 'tags', 'label', 'enableMailbox', 'mailboxDisplayName', 'mailboxName', 'mailboxDomain', 'enableInbox', 'inboxName', 'inboxDomain', 'devices', - 'enableTurn', 'enableRedis', 'mounts', 'enableBackup', 'enableAutomaticUpdate', 'accessRestriction', 'operators', 'sso'); + 'enableTurn', 'enableRedis', 'mounts', 'enableBackup', 'enableAutomaticUpdate', 'accessRestriction', 'operators', 'sso', + 'notes', 'checklist'); // intentionally not filled up: redirectDomain, aliasDomains, mailboxDomain const newAppData = Object.assign(dolly, {