From aa65af10b6b491d16465f0c1db6c50631c8c0163 Mon Sep 17 00:00:00 2001
From: Johannes Zellner <johannes@cloudron.io>
Date: Mon, 17 Feb 2025 13:33:47 +0100
Subject: [PATCH] Bring back app configure link

---
 dashboard/src/views/AppsView.vue | 63 +++++++++++++++++---------------
 1 file changed, 33 insertions(+), 30 deletions(-)

diff --git a/dashboard/src/views/AppsView.vue b/dashboard/src/views/AppsView.vue
index bfda38091..4ccbce16e 100644
--- a/dashboard/src/views/AppsView.vue
+++ b/dashboard/src/views/AppsView.vue
@@ -100,9 +100,12 @@ const appProgressMessage = AppsModel.appProgressMessage;
 
 const applinkDialog = useTemplateRef('applinkDialog');
 
-function openAppEdit(app) {
-  if (app.type === APP_TYPES.LINK) applinkDialog.value.open(app);
-  else window.location.href = `#/app/${app.id}/info`;
+// hook for applinks otherwise it is a link
+function openAppEdit(app, event) {
+  if (app.type === APP_TYPES.LINK) {
+    applinkDialog.value.open(app);
+    event.preventDefault();
+  }
 }
 
 function onOpenApp(app, event) {
@@ -214,7 +217,7 @@ onUnmounted(() => {
     <div v-show="ready">
       <TransitionGroup name="grid-animation" tag="div" class="grid" v-if="viewType === VIEW_TYPE.GRID">
         <a v-for="app in filteredApps" :key="app.id" class="grid-item" @click="onOpenApp(app, $event)" :href="'https://' + app.fqdn" target="_blank">
-          <div class="config" v-show="isOperator(app)" @click.prevent="openAppEdit(app)"><Icon icon="fa-solid fa-cog" /></div>
+          <a class="config" v-show="isOperator(app)" @click="openAppEdit(app, $event)" :href="`#/app/${app.id}/info`"><Icon icon="fa-solid fa-cog" /></a>
           <img :src="API_ORIGIN + app.iconUrl" v-fallback-image="API_ORIGIN + '/img/appicon_fallback.png'"/>
           <div class="grid-item-label">{{ app.label || app.subdomain || app.fqdn }}</div>
           <div class="grid-item-task-label">{{ installationStateLabel(app) }}</div>
@@ -226,49 +229,49 @@ onUnmounted(() => {
 
       <div class="list" v-if="viewType === VIEW_TYPE.LIST">
         <TableView :columns="listColumns" :model="filteredApps">
-          <template #icon="slotProps">
-            <a :href="'https://' + slotProps.fqdn" target="_blank">
-              <img class="list-icon" :src="API_ORIGIN + slotProps.iconUrl" v-fallback-image="API_ORIGIN + '/img/appicon_fallback.png'"/>
+          <template #icon="app">
+            <a :href="'https://' + app.fqdn" target="_blank">
+              <img class="list-icon" :src="API_ORIGIN + app.iconUrl" v-fallback-image="API_ORIGIN + '/img/appicon_fallback.png'"/>
             </a>
           </template>
-          <template #label="slotProps">
-            <a :href="'https://' + slotProps.fqdn" target="_blank">
-              {{ slotProps.label || slotProps.subdomain || slotProps.fqdn }}
+          <template #label="app">
+            <a :href="'https://' + app.fqdn" target="_blank">
+              {{ app.label || app.subdomain || app.fqdn }}
             </a>
           </template>
-          <template #appTitle="slotProps">
-            {{ slotProps.manifest.title }}
+          <template #appTitle="app">
+            {{ app.manifest.title }}
           </template>
-          <template #domain="slotProps">
-            <a :href="'https://' + slotProps.fqdn" target="_blank">
-              {{ slotProps.fqdn }}
+          <template #domain="app">
+            <a :href="'https://' + app.fqdn" target="_blank">
+              {{ app.fqdn }}
             </a>
           </template>
-          <template #status="slotProps">
+          <template #status="app">
             <div class="list-status">
-              {{ installationStateLabel(slotProps) }}
-              <div class="apps-progress" v-show="isOperator(slotProps)">
-                <div class="apps-progress-filled" :style="{ width: slotProps.progress+'%' }"></div>
+              {{ installationStateLabel(app) }}
+              <div class="apps-progress" v-show="isOperator(app)">
+                <div class="apps-progress-filled" :style="{ width: app.progress+'%' }"></div>
               </div>
             </div>
           </template>
-          <template #sso="slotProps">
-            <div v-show="slotProps.type !== APP_TYPES.LINK">
-              <Icon icon="fa-brands fa-openid" v-show="slotProps.ssoAuth && slotProps.manifest.addons.oidc" v-tooltip="$t('apps.auth.openid')" />
-              <Icon icon="fas fa-user" v-show="slotProps.ssoAuth && (!slotProps.manifest.addons.oidc && !slotProps.manifest.addons.email)" v-tooltip="$t('apps.auth.sso')" />
-              <Icon icon="far fa-user" v-show="!slotProps.ssoAuth && !slotProps.manifest.addons.email" v-tooltip="$t('apps.auth.nosso')" />
-              <Icon icon="fas fa-envelope" v-show="slotProps.manifest.addons.email" v-tooltip="$t('apps.auth.email')" />
+          <template #sso="app">
+            <div v-show="app.type !== APP_TYPES.LINK">
+              <Icon icon="fa-brands fa-openid" v-show="app.ssoAuth && app.manifest.addons.oidc" v-tooltip="$t('apps.auth.openid')" />
+              <Icon icon="fas fa-user" v-show="app.ssoAuth && (!app.manifest.addons.oidc && !app.manifest.addons.email)" v-tooltip="$t('apps.auth.sso')" />
+              <Icon icon="far fa-user" v-show="!app.ssoAuth && !app.manifest.addons.email" v-tooltip="$t('apps.auth.nosso')" />
+              <Icon icon="fas fa-envelope" v-show="app.manifest.addons.email" v-tooltip="$t('apps.auth.email')" />
             </div>
           </template>
-          <template #actions="slotProps">
+          <template #actions="app">
             <div class="table-actions">
               <ButtonGroup>
-                <Button small secondary tool v-if="slotProps.type !== APP_TYPES.LINK" :href="'/logs.html?appId=' + slotProps.id" target="_blank" v-tooltip="$t('app.logsActionTooltip')" icon="fas fa-align-left"></Button>
-                <Button small secondary tool v-if="slotProps.type !== APP_TYPES.PROXIED && slotProps.type !== APP_TYPES.LINK" :href="'/terminal.html?id=' + slotProps.id" target="_blank" v-tooltip="$t('app.terminalActionTooltip')" icon="fa fa-terminal"></Button>
-                <Button small secondary tool v-if="slotProps.manifest.addons.localstorage" :href="'/filemanager.html#/home/app/' + slotProps.id" target="_blank" v-tooltip="$t('app.filemanagerActionTooltip')" icon="fas fa-folder"></Button>
+                <Button small secondary tool v-if="app.type !== APP_TYPES.LINK" :href="'/logs.html?appId=' + app.id" target="_blank" v-tooltip="$t('app.logsActionTooltip')" icon="fas fa-align-left"></Button>
+                <Button small secondary tool v-if="app.type !== APP_TYPES.PROXIED && app.type !== APP_TYPES.LINK" :href="'/terminal.html?id=' + app.id" target="_blank" v-tooltip="$t('app.terminalActionTooltip')" icon="fa fa-terminal"></Button>
+                <Button small secondary tool v-if="app.manifest.addons.localstorage" :href="'/filemanager.html#/home/app/' + app.id" target="_blank" v-tooltip="$t('app.filemanagerActionTooltip')" icon="fas fa-folder"></Button>
               </ButtonGroup>
 
-              <Button small secondary tool @click="openAppEdit(slotProps)" icon="fa-solid fa-cog"></Button>
+              <Button small secondary tool @click="openAppEdit(app, $event)" :href="`#/app/${app.id}/info`" icon="fa-solid fa-cog"></Button>
             </div>
           </template>
         </TableView>