From aa396656d7af5ccce5df999719226bfbbea16059 Mon Sep 17 00:00:00 2001 From: Girish Ramakrishnan Date: Fri, 23 May 2014 13:07:41 -0700 Subject: [PATCH] Fix jshint errors --- src/apps.js | 12 +++++++----- src/routes/apps.js | 4 +++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/apps.js b/src/apps.js index 4a56f12b6..7dec41869 100644 --- a/src/apps.js +++ b/src/apps.js @@ -1,3 +1,5 @@ +/* jslint node:true */ + 'use strict'; var DatabaseError = require('./databaseerror.js'), @@ -122,7 +124,7 @@ Task.prototype.downloadApp = function (manifest, callback) { }; Task.prototype.runApp = function (manifest, config, callback) { - var outputStream = Writable(), + var outputStream = new Writable(), docker = this._docker; outputStream._write = function (chunk, enc, callback) { @@ -189,12 +191,12 @@ Task.prototype.refresh = function () { res.on('end', function () { var rawManifest = Buffer.concat(bufs); var manifest = safe(function () { return yaml.safeLoad(rawManifest.toString('utf8')); }); - if (manifest == null) { + if (manifest === null) { debug('Error parsing manifest: ' + safe.error); return callback(null); } - that.downloadApp(manifest, function (error) { + that.downloadApp(manifest, function (error) { if (error) { console.error('Error downloading application', error); return callback(null); @@ -203,10 +205,10 @@ Task.prototype.refresh = function () { that.runApp(manifest, app.config, callback); }); }); - }); + }); }, function callback(err) { that._refreshing = false; - if (that._pendingRefresh) process.nextTick(refresh.bind(that)); + if (that._pendingRefresh) process.nextTick(that.refresh.bind(that)); that._pendingRefresh = false; }); diff --git a/src/routes/apps.js b/src/routes/apps.js index 44d1a6594..cea139670 100644 --- a/src/routes/apps.js +++ b/src/routes/apps.js @@ -1,3 +1,5 @@ +/* jslint node:true */ + 'use strict'; var HttpError = require('../httperror.js'), @@ -17,7 +19,7 @@ function initialize(config) { function installApp(req, res, next) { var data = req.body; - if (!data) return next(new HttpError(400, 'Cannot parse data field:' + safe.error.message)); + if (!data) return next(new HttpError(400, 'Cannot parse data field')); if (!data.app_id) return next(new HttpError(400, 'app_id is required')); if (!data.password) return next(new HttpError(400, 'password is required')); if (!data.config) return next(new HttpError(400, 'config is required'));