settings: move dynamic dns to network

and add tests

src/cron.js

@@ -12,6 +12,7 @@ exports = module.exports = {
     stopJobs,
 
     handleSettingsChanged,
+    dynamicDnsChanged,
 
     DEFAULT_AUTOUPDATE_PATTERN,
 };
@@ -28,6 +29,7 @@ const appHealthMonitor = require('./apphealthmonitor.js'),
     dyndns = require('./dyndns.js'),
     eventlog = require('./eventlog.js'),
     janitor = require('./janitor.js'),
+    network = require('./network.js'),
     paths = require('./paths.js'),
     safe = require('safetydance'),
     scheduler = require('./scheduler.js'),
@@ -163,7 +165,7 @@ async function startJobs() {
     const tz = allSettings[settings.TIME_ZONE_KEY];
     backupPolicyChanged(allSettings[settings.BACKUP_POLICY_KEY], tz);
     autoupdatePatternChanged(allSettings[settings.AUTOUPDATE_PATTERN_KEY], tz);
-    dynamicDnsChanged(allSettings[settings.DYNAMIC_DNS_KEY]);
+    dynamicDnsChanged(await network.getDynamicDns());
 }
 
 // eslint-disable-next-line no-unused-vars
@@ -175,7 +177,6 @@ async function handleSettingsChanged(key, value) {
     case settings.TIME_ZONE_KEY:
     case settings.BACKUP_CONFIG_KEY:
     case settings.AUTOUPDATE_PATTERN_KEY:
-    case settings.DYNAMIC_DNS_KEY:
         debug('handleSettingsChanged: recreating all jobs');
         await stopJobs();
         await startJobs();