From a112e614e60bb4b81d201dc06fb9a2f6a81c94a5 Mon Sep 17 00:00:00 2001 From: Johannes Zellner Date: Fri, 1 Apr 2016 21:43:48 +0200 Subject: [PATCH] Actually query by username instead of just delegate to get() in getByUsername() --- src/userdb.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/userdb.js b/src/userdb.js index f923512ed..7d614a2f3 100644 --- a/src/userdb.js +++ b/src/userdb.js @@ -41,8 +41,12 @@ function getByUsername(username, callback) { assert.strictEqual(typeof username, 'string'); assert.strictEqual(typeof callback, 'function'); - // currently username is also our id - get(username, callback); + database.query('SELECT ' + USERS_FIELDS + ' FROM users WHERE username = ?', [ username ], function (error, result) { + if (error) return callback(new DatabaseError(DatabaseError.INTERNAL_ERROR, error)); + if (result.length === 0) return callback(new DatabaseError(DatabaseError.NOT_FOUND)); + + callback(null, result[0]); + }); } function getByEmail(email, callback) {