backups: split config and policy

keeping them together makes the test/validation quite complicated.
for example, when policy is changed, we test the storage backends

part of #817

src/routes/settings.js

@@ -72,7 +72,6 @@ async function setBackupConfig(req, res, next) {
     assert.strictEqual(typeof req.body, 'object');
 
     if (typeof req.body.provider !== 'string') return next(new HttpError(400, 'provider is required'));
-    if (typeof req.body.schedulePattern !== 'string') return next(new HttpError(400, 'schedulePattern is required'));
     if ('password' in req.body && typeof req.body.password !== 'string') return next(new HttpError(400, 'password must be a string'));
     if ('encryptedFilenames' in req.body && typeof req.body.encryptedFilenames !== 'boolean') return next(new HttpError(400, 'encryptedFilenames must be a boolean'));
 
@@ -101,8 +100,6 @@ async function setBackupConfig(req, res, next) {
     if (typeof req.body.format !== 'string') return next(new HttpError(400, 'format must be a string'));
     if ('acceptSelfSignedCerts' in req.body && typeof req.body.acceptSelfSignedCerts !== 'boolean') return next(new HttpError(400, 'format must be a boolean'));
 
-    if (!req.body.retentionPolicy || typeof req.body.retentionPolicy !== 'object') return next(new HttpError(400, 'retentionPolicy is required'));
-
     if ('mountOptions' in req.body && typeof req.body.mountOptions !== 'object') return next(new HttpError(400, 'mountOptions must be a object'));
 
     // testing the backup using put/del takes a bit of time at times
@@ -177,6 +174,25 @@ async function setDynamicDnsConfig(req, res, next) {
     next(new HttpSuccess(200, {}));
 }
 
+async function getBackupPolicy(req, res, next) {
+    const [error, policy] = await safe(settings.getBackupPolicy());
+    if (error) return next(BoxError.toHttpError(error));
+
+    next(new HttpSuccess(200, { policy }));
+}
+
+async function setBackupPolicy(req, res, next) {
+    assert.strictEqual(typeof req.body, 'object');
+
+    if (typeof req.body.schedule !== 'string') return next(new HttpError(400, 'schedule is required'));
+    if (!req.body.retention || typeof req.body.retention !== 'object') return next(new HttpError(400, 'retention is required'));
+
+    const [error] = await safe(settings.setBackupPolicy(req.body));
+    if (error) return next(BoxError.toHttpError(error));
+
+    next(new HttpSuccess(200, {}));
+}
+
 async function getIPv6Config(req, res, next) {
     const [error, ipv6Config] = await safe(settings.getIPv6Config());
     if (error) return next(BoxError.toHttpError(error));
@@ -296,6 +312,7 @@ function get(req, res, next) {
     assert.strictEqual(typeof req.params.setting, 'string');
 
     switch (req.params.setting) {
+    case settings.BACKUP_POLICY_KEY: return getBackupPolicy(req, res, next);
     case settings.DYNAMIC_DNS_KEY: return getDynamicDnsConfig(req, res, next);
     case settings.IPV6_CONFIG_KEY: return getIPv6Config(req, res, next);
     case settings.BACKUP_CONFIG_KEY: return getBackupConfig(req, res, next);
@@ -320,6 +337,7 @@ function set(req, res, next) {
     assert.strictEqual(typeof req.body, 'object');
 
     switch (req.params.setting) {
+    case settings.BACKUP_POLICY_KEY: return setBackupPolicy(req, res, next);
     case settings.DYNAMIC_DNS_KEY: return setDynamicDnsConfig(req, res, next);
     case settings.IPV6_CONFIG_KEY: return setIPv6Config(req, res, next);
     case settings.EXTERNAL_LDAP_KEY: return setExternalLdapConfig(req, res, next);