From 9a6d8e3a336d89607d6a5ec4188c4a6d6848bae0 Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Wed, 13 Mar 2019 10:48:42 -0700
Subject: [PATCH] Handle access denied in registerSubdomain

---
 src/apptask.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/apptask.js b/src/apptask.js
index de2377bec..8c92bec86 100644
--- a/src/apptask.js
+++ b/src/apptask.js
@@ -295,7 +295,8 @@ function registerSubdomain(app, overwrite, callback) {
 
             // get the current record before updating it
             domains.getDnsRecords(app.location, app.domain, 'A', function (error, values) {
-                if (error) return retryCallback(error);
+                if (error && error.reason === DomainsError.EXTERNAL_ERROR) return retryCallback(error); // try again
+                if (error) return retryCallback(null, error); // give up for access and other errors
 
                 // refuse to update any existing DNS record for custom domains that we did not create
                 if (values.length !== 0 && !overwrite) return retryCallback(null, new Error('DNS Record already exists'));