Migrate codebase from CommonJS to ES Modules
- Convert all require()/module.exports to import/export across 260+ files - Add "type": "module" to package.json to enable ESM by default - Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible - Convert eslint.config.js to ESM with sourceType: "module" - Replace __dirname/__filename with import.meta.dirname/import.meta.filename - Replace require.main === module with process.argv[1] === import.meta.filename - Remove 'use strict' directives (implicit in ESM) - Convert dynamic require() in switch statements to static import lookup maps (dns.js, domains.js, backupformats.js, backupsites.js, network.js) - Extract self-referencing exports.CONSTANT patterns into standalone const declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.) - Lazify SERVICES object in services.js to avoid circular dependency TDZ issues - Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests - Add _setMockApp() to ldapserver.js for ESM-safe test mocking - Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests - Convert backupupload.js to use dynamic imports so --check exits before loading the module graph (which requires BOX_ENV) - Update check-install to use ESM import for infra_version.js - Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations) - All 1315 tests passing Migration stats (AI-assisted using Cursor with Claude): - Wall clock time: ~3-4 hours - Assistant completions: ~80-100 - Estimated token usage: ~1-2M tokens Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -1,22 +1,22 @@
|
||||
/* jslint node:true */
|
||||
|
||||
import * as common from './common.js';
|
||||
import DataLayout from '../datalayout.js';
|
||||
import * as tgz from '../backupformat/tgz.js';
|
||||
const EnsureFileSizeStream = tgz._EnsureFileSizeStream;
|
||||
import expect from 'expect.js';
|
||||
import fs from 'node:fs';
|
||||
import os from 'node:os';
|
||||
import path from 'node:path';
|
||||
import * as rsync from '../backupformat/rsync.js';
|
||||
import safe from 'safetydance';
|
||||
import stream from 'node:stream/promises';
|
||||
|
||||
/* global it:false */
|
||||
/* global describe:false */
|
||||
/* global before:false */
|
||||
/* global after:false */
|
||||
|
||||
'use strict';
|
||||
|
||||
const common = require('./common.js'),
|
||||
DataLayout = require('../datalayout.js'),
|
||||
EnsureFileSizeStream = require('../backupformat/tgz.js')._EnsureFileSizeStream,
|
||||
expect = require('expect.js'),
|
||||
fs = require('node:fs'),
|
||||
os = require('node:os'),
|
||||
path = require('node:path'),
|
||||
rsync = require('../backupformat/rsync.js'),
|
||||
safe = require('safetydance'),
|
||||
stream = require('node:stream/promises');
|
||||
|
||||
describe('backuptask', function () {
|
||||
const { setup, cleanup, createTree } = common;
|
||||
|
||||
@@ -77,7 +77,7 @@ describe('backuptask', function () {
|
||||
createTree(tmpdir, { 'data': { 'subdir': { 'emptydir': { } } }, 'dir2': { 'file': 'stuff' } });
|
||||
fs.chmodSync(path.join(tmpdir, 'dir2/file'), parseInt('0755', 8));
|
||||
|
||||
let dataLayout = new DataLayout(tmpdir, []);
|
||||
const dataLayout = new DataLayout(tmpdir, []);
|
||||
|
||||
await rsync._saveFsMetadata(dataLayout, `${dataLayout.localRoot()}/fsmetadata.json`);
|
||||
|
||||
@@ -93,7 +93,7 @@ describe('backuptask', function () {
|
||||
|
||||
expect(fs.existsSync(path.join(tmpdir, 'data/subdir/emptydir'))).to.be(false); // just make sure rimraf worked
|
||||
|
||||
let dataLayout = new DataLayout(tmpdir, []);
|
||||
const dataLayout = new DataLayout(tmpdir, []);
|
||||
|
||||
await rsync._restoreFsMetadata(dataLayout, `${dataLayout.localRoot()}/fsmetadata.json`);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user