Migrate codebase from CommonJS to ES Modules

- Convert all require()/module.exports to import/export across 260+ files
- Add "type": "module" to package.json to enable ESM by default
- Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible
- Convert eslint.config.js to ESM with sourceType: "module"
- Replace __dirname/__filename with import.meta.dirname/import.meta.filename
- Replace require.main === module with process.argv[1] === import.meta.filename
- Remove 'use strict' directives (implicit in ESM)
- Convert dynamic require() in switch statements to static import lookup maps
  (dns.js, domains.js, backupformats.js, backupsites.js, network.js)
- Extract self-referencing exports.CONSTANT patterns into standalone const
  declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.)
- Lazify SERVICES object in services.js to avoid circular dependency TDZ issues
- Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests
- Add _setMockApp() to ldapserver.js for ESM-safe test mocking
- Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests
- Convert backupupload.js to use dynamic imports so --check exits before
  loading the module graph (which requires BOX_ENV)
- Update check-install to use ESM import for infra_version.js
- Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations)
- All 1315 tests passing

Migration stats (AI-assisted using Cursor with Claude):
- Wall clock time: ~3-4 hours
- Assistant completions: ~80-100
- Estimated token usage: ~1-2M tokens

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Girish Ramakrishnan
2026-02-14 09:53:14 +01:00
parent e0e9f14a5e
commit 96dc79cfe6
277 changed files with 4789 additions and 3811 deletions
+25 -25
View File
@@ -1,35 +1,35 @@
'use strict';
import apps from './apps.js';
import assert from 'node:assert';
import blobs from './blobs.js';
import constants from './constants.js';
import * as dashboard from './dashboard.js';
import debugModule from 'debug';
import ejs from 'ejs';
import express from 'express';
import fs from 'node:fs';
import path from 'node:path';
import paths from './paths.js';
import hat from './hat.js';
import http from 'node:http';
import { HttpError } from '@cloudron/connect-lastmile';
import { HttpSuccess } from '@cloudron/connect-lastmile';
import jwt from 'jsonwebtoken';
import * as middleware from './middleware/index.js';
import * as oidcServer from './oidcserver.js';
import safe from 'safetydance';
import * as settings from './settings.js';
import * as users from './users.js';
import util from 'node:util';
const debug = debugModule('box:proxyAuth');
// heavily inspired from https://gock.net/blog/2020/nginx-subrequest-authentication-server/ and https://github.com/andygock/auth-server
exports = module.exports = {
export {
start,
stop
};
const apps = require('./apps.js'),
assert = require('node:assert'),
blobs = require('./blobs.js'),
constants = require('./constants.js'),
dashboard = require('./dashboard.js'),
debug = require('debug')('box:proxyAuth'),
ejs = require('ejs'),
express = require('express'),
fs = require('node:fs'),
path = require('node:path'),
paths = require('./paths.js'),
hat = require('./hat.js'),
http = require('node:http'),
HttpError = require('@cloudron/connect-lastmile').HttpError,
HttpSuccess = require('@cloudron/connect-lastmile').HttpSuccess,
jwt = require('jsonwebtoken'),
middleware = require('./middleware'),
oidcServer = require('./oidcserver.js'),
safe = require('safetydance'),
settings = require('./settings.js'),
users = require('./users.js'),
util = require('node:util');
let gHttpServer = null;
let gTokenSecret = null;