Migrate codebase from CommonJS to ES Modules

- Convert all require()/module.exports to import/export across 260+ files
- Add "type": "module" to package.json to enable ESM by default
- Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible
- Convert eslint.config.js to ESM with sourceType: "module"
- Replace __dirname/__filename with import.meta.dirname/import.meta.filename
- Replace require.main === module with process.argv[1] === import.meta.filename
- Remove 'use strict' directives (implicit in ESM)
- Convert dynamic require() in switch statements to static import lookup maps
  (dns.js, domains.js, backupformats.js, backupsites.js, network.js)
- Extract self-referencing exports.CONSTANT patterns into standalone const
  declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.)
- Lazify SERVICES object in services.js to avoid circular dependency TDZ issues
- Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests
- Add _setMockApp() to ldapserver.js for ESM-safe test mocking
- Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests
- Convert backupupload.js to use dynamic imports so --check exits before
  loading the module graph (which requires BOX_ENV)
- Update check-install to use ESM import for infra_version.js
- Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations)
- All 1315 tests passing

Migration stats (AI-assisted using Cursor with Claude):
- Wall clock time: ~3-4 hours
- Assistant completions: ~80-100
- Estimated token usage: ~1-2M tokens

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Girish Ramakrishnan
2026-02-14 09:53:14 +01:00
parent e0e9f14a5e
commit 96dc79cfe6
277 changed files with 4789 additions and 3811 deletions
+17 -17
View File
@@ -1,6 +1,21 @@
'use strict';
import assert from 'node:assert';
import BoxError from './boxerror.js';
import crypto from 'node:crypto';
import * as dashboard from './dashboard.js';
import * as database from './database.js';
import debugModule from 'debug';
import safe from 'safetydance';
import {
generateRegistrationOptions as generateWebAuthnRegistrationOptions,
verifyRegistrationResponse,
generateAuthenticationOptions as generateWebAuthnAuthenticationOptions,
verifyAuthenticationResponse
} from '@simplewebauthn/server';
import * as _ from './underscore.js';
exports = module.exports = {
const debug = debugModule('box:passkeys');
export {
list,
get,
getByCredentialId,
@@ -16,21 +31,6 @@ exports = module.exports = {
removePrivateFields
};
const assert = require('node:assert'),
BoxError = require('./boxerror.js'),
crypto = require('node:crypto'),
dashboard = require('./dashboard.js'),
database = require('./database.js'),
debug = require('debug')('box:passkeys'),
safe = require('safetydance'),
{
generateRegistrationOptions: generateWebAuthnRegistrationOptions,
verifyRegistrationResponse,
generateAuthenticationOptions: generateWebAuthnAuthenticationOptions,
verifyAuthenticationResponse
} = require('@simplewebauthn/server'),
_ = require('./underscore.js');
const PASSKEY_FIELDS = [ 'id', 'userId', 'credentialId', 'publicKey', 'counter', 'transports', 'name', 'creationTime', 'lastUsedTime' ].join(',');
// In-memory challenge store with expiration (challenges are short-lived)