Migrate codebase from CommonJS to ES Modules

- Convert all require()/module.exports to import/export across 260+ files
- Add "type": "module" to package.json to enable ESM by default
- Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible
- Convert eslint.config.js to ESM with sourceType: "module"
- Replace __dirname/__filename with import.meta.dirname/import.meta.filename
- Replace require.main === module with process.argv[1] === import.meta.filename
- Remove 'use strict' directives (implicit in ESM)
- Convert dynamic require() in switch statements to static import lookup maps
  (dns.js, domains.js, backupformats.js, backupsites.js, network.js)
- Extract self-referencing exports.CONSTANT patterns into standalone const
  declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.)
- Lazify SERVICES object in services.js to avoid circular dependency TDZ issues
- Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests
- Add _setMockApp() to ldapserver.js for ESM-safe test mocking
- Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests
- Convert backupupload.js to use dynamic imports so --check exits before
  loading the module graph (which requires BOX_ENV)
- Update check-install to use ESM import for infra_version.js
- Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations)
- All 1315 tests passing

Migration stats (AI-assisted using Cursor with Claude):
- Wall clock time: ~3-4 hours
- Assistant completions: ~80-100
- Estimated token usage: ~1-2M tokens

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Girish Ramakrishnan
2026-02-14 09:53:14 +01:00
parent e0e9f14a5e
commit 96dc79cfe6
277 changed files with 4789 additions and 3811 deletions
+49 -43
View File
@@ -1,6 +1,44 @@
'use strict';
import apps from './apps.js';
import assert from 'node:assert';
import BoxError from './boxerror.js';
import constants from './constants.js';
import * as dashboard from './dashboard.js';
import debugModule from 'debug';
import * as domains from './domains.js';
import * as ipaddr from './ipaddr.js';
import * as mail from './mail.js';
import * as mailServer from './mailserver.js';
import * as network from './network.js';
import promiseRetry from './promise-retry.js';
import safe from 'safetydance';
import tasks from './tasks.js';
import tld from 'tldjs';
import * as dnsBunny from './dns/bunny.js';
import * as dnsCloudflare from './dns/cloudflare.js';
import * as dnsDesec from './dns/desec.js';
import * as dnsDnsimple from './dns/dnsimple.js';
import * as dnsRoute53 from './dns/route53.js';
import * as dnsGcdns from './dns/gcdns.js';
import * as dnsDigitalocean from './dns/digitalocean.js';
import * as dnsGandi from './dns/gandi.js';
import * as dnsGodaddy from './dns/godaddy.js';
import * as dnsInwx from './dns/inwx.js';
import * as dnsLinode from './dns/linode.js';
import * as dnsVultr from './dns/vultr.js';
import * as dnsNamecom from './dns/namecom.js';
import * as dnsNamecheap from './dns/namecheap.js';
import * as dnsNetcup from './dns/netcup.js';
import * as dnsHetzner from './dns/hetzner.js';
import * as dnsHetznercloud from './dns/hetznercloud.js';
import * as dnsNoop from './dns/noop.js';
import * as dnsManual from './dns/manual.js';
import * as dnsOvh from './dns/ovh.js';
import * as dnsPorkbun from './dns/porkbun.js';
import * as dnsWildcard from './dns/wildcard.js';
exports = module.exports = {
const debug = debugModule('box:dns');
export {
fqdn,
getName,
@@ -23,51 +61,20 @@ exports = module.exports = {
startSyncDnsRecords
};
const apps = require('./apps.js'),
assert = require('node:assert'),
BoxError = require('./boxerror.js'),
constants = require('./constants.js'),
dashboard = require('./dashboard.js'),
debug = require('debug')('box:dns'),
domains = require('./domains.js'),
ipaddr = require('./ipaddr.js'),
mail = require('./mail.js'),
mailServer = require('./mailserver.js'),
network = require('./network.js'),
promiseRetry = require('./promise-retry.js'),
safe = require('safetydance'),
tasks = require('./tasks.js'),
tld = require('tldjs');
const DNS_PROVIDERS = {
bunny: dnsBunny, cloudflare: dnsCloudflare, desec: dnsDesec, dnsimple: dnsDnsimple,
route53: dnsRoute53, gcdns: dnsGcdns, digitalocean: dnsDigitalocean, gandi: dnsGandi,
godaddy: dnsGodaddy, inwx: dnsInwx, linode: dnsLinode, vultr: dnsVultr,
namecom: dnsNamecom, namecheap: dnsNamecheap, netcup: dnsNetcup, hetzner: dnsHetzner,
hetznercloud: dnsHetznercloud, noop: dnsNoop, manual: dnsManual, ovh: dnsOvh,
porkbun: dnsPorkbun, wildcard: dnsWildcard
};
// choose which subdomain backend we use for test purpose we use route53
function api(provider) {
assert.strictEqual(typeof provider, 'string');
switch (provider) {
case 'bunny': return require('./dns/bunny.js');
case 'cloudflare': return require('./dns/cloudflare.js');
case 'desec': return require('./dns/desec.js');
case 'dnsimple': return require('./dns/dnsimple.js');
case 'route53': return require('./dns/route53.js');
case 'gcdns': return require('./dns/gcdns.js');
case 'digitalocean': return require('./dns/digitalocean.js');
case 'gandi': return require('./dns/gandi.js');
case 'godaddy': return require('./dns/godaddy.js');
case 'inwx': return require('./dns/inwx.js');
case 'linode': return require('./dns/linode.js');
case 'vultr': return require('./dns/vultr.js');
case 'namecom': return require('./dns/namecom.js');
case 'namecheap': return require('./dns/namecheap.js');
case 'netcup': return require('./dns/netcup.js');
case 'hetzner': return require('./dns/hetzner.js');
case 'hetznercloud': return require('./dns/hetznercloud.js');
case 'noop': return require('./dns/noop.js');
case 'manual': return require('./dns/manual.js');
case 'ovh': return require('./dns/ovh.js');
case 'porkbun': return require('./dns/porkbun.js');
case 'wildcard': return require('./dns/wildcard.js');
default: return null;
}
return DNS_PROVIDERS[provider] || null;
}
function fqdn(subdomain, domain) {
@@ -373,7 +380,6 @@ async function syncDnsRecords(options, progressCallback) {
return { errors };
}
async function startSyncDnsRecords(options) {
assert.strictEqual(typeof options, 'object');